GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Generate the docs screenshots with Playwright by Bohreromir · Pull Request #456 · stackabletech/cockpit

Conversation

@Bohreromir

@Bohreromir Bohreromir commented Nov 10, 2026

Copy link
Copy Markdown
Member

Description

Adds a script to update screenshots automatically with npm run docs:screenshots

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Bohreromir added 17 commits October 30, 2026 12:16
@Bohreromir
feat(docs): first draft
eba1467
@Bohreromir
docs: Version the docs with the SDP like the operators
6d08dfd 
Cockpit is released together with the SDP, so the docs become the
'cockpit' module of the 'home' component instead of a component of
their own. The release scripts set the version on release branches.
@Bohreromir
docs: Install the published Helm chart
daccaea
@Bohreromir
style(docs): Use single quotes in antora.yml
51be4e3
@Bohreromir
docs: Fix bookmark key and database TLS in getting started
d3c5073
@Bohreromir
docs: Add the OIDC redirect URI to getting started
5b0e502
@Bohreromir
docs: Address review findings
5e41826
@Bohreromir
docs: Document startup validation, logging variables and global bookm…
5e1e5df 
…ark rules
@Bohreromir
Merge branch 'main' into worktree-docs-antora
b55afdd
@Bohreromir
docs(trino): Document how Trino errors are shown
9968d84
@Bohreromir
docs(helm): Document that Cockpit must be served at the root path
d878b8e
@Bohreromir
docs: Name the generated session Secret and list all prerequisites
5feb5f8 
Getting started also needs the Secret Operator for the SecretClasses
and an Ingress or reverse proxy that serves Cockpit over HTTPS.
@Bohreromir
Merge branch 'main' into worktree-docs-antora
95a2d7c
@Bohreromir
docs: Fix the OIDC redirect URI and Trino URL in examples
6e046e8 
better-auth 1.7 serves the generic OAuth callback at
/api/auth/callback/oidc. The Trino TLS certificate from the Secret
Operator covers the headless role group Service, not trino-coordinator.
@Bohreromir
docs(helm): Document the proxy buffer size for large response headers
7921eb0
@Bohreromir
docs: pr feedback
4d8bbe3
@Bohreromir
docs: Add a dashboard screenshot to the overview page
10d305a
@Bohreromir
Bohreromir added this pull request to stack #455 November 10, 2026 19:17
@Bohreromir Bohreromir mentioned this pull request Nov 10, 2026
Add docs #422
Merged
1 of 6 tasks
@github-actions

github-actions Bot commented Nov 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.5% 9184 / 13605
🔵 Statements 66.45% 12364 / 18604
🔵 Functions 68.29% 2966 / 4343
🔵 Branches 57.45% 5180 / 9015
File CoverageNo changed files found.
Generated in workflow #1269 for commit fc08ff1 by the Vitest Coverage Report Action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Bohreromir added 3 commits November 10, 2026 20:20
@Bohreromir
Merge branch 'main' into worktree-docs-antora
e7de79d
@Bohreromir
fix(db): Default DATABASE_PORT to 5432
866a5ac 
The fallback was the NodePort of the kind dev setup (31432), which sets
the port explicitly anyway. Use the standard PostgreSQL port instead.
@Bohreromir
test(e2e): Generate the docs screenshots with Playwright
fc08ff1 
npm run docs:screenshots builds with .env.test and runs the specs in
e2e/docs-screenshots in a separate Playwright project, which writes the
images to docs/modules/cockpit/images. The normal E2E run skips them.
@Bohreromir
Bohreromir force-pushed the docs/screenshots-script branch from fb4ea57 to fc08ff1 Compare November 10, 2026 19:21
@Bohreromir
Bohreromir marked this pull request as ready for review November 10, 2026 19:22
@Bohreromir Bohreromir self-assigned this Nov 10, 2026
@Bohreromir Bohreromir added this to Stackable Engineering Nov 10, 2026
@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Nov 10, 2026
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 11, 2026
@dervoeti
dervoeti self-requested a review November 11, 2026 09:15
dervoeti
dervoeti reviewed Nov 11, 2026
View reviewed changes

@dervoeti dervoeti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good to me, Claude found one thing that sounds reasonable:

The screenshot depends on the fonts of the machine that runs it (e2e/docs-screenshots/dashboard.spec.ts:56, playwright.config.ts:10). Neither src/app.css nor package.json bundles a font, so the app falls back to the Tailwind system font stack. Every contributor who runs the script will commit a slightly different binary and the docs will keep changing look.

Fix:

  • Option 1: run the docs project in the official Playwright container (mcr.microsoft.com/playwright:v<same version as @playwright/test>-noble).
  • Option 2: bundle a web font.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Base automatically changed from fix/db-default-port to main November 12, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dervoeti dervoeti dervoeti left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Bohreromir Bohreromir

Labels

None yet

Projects

Stackable Engineering
Status: Development: In Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Bohreromir @dervoeti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.