GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix broken binary preview for KNOWN_BINARY_TYPES by Bohreromir · Pull Request #470 · stackabletech/cockpit

Conversation

@Bohreromir

@Bohreromir Bohreromir commented Nov 12, 2026

Copy link
Copy Markdown
Member

Description

For content types in KNOWN_BINARY_TYPES the preview endpoint returns an empty body with X-Preview-Renderable: false. The preview modal ignored that header, decoded the empty body as valid UTF-8 and showed an empty, read-only text editor instead of the binary fallback.

Check the header right after the 7z/rar checks and show the fallback. The unit test mock now sends the real binaryPreview() headers, and an E2E test covers an application/avro object.

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Bohreromir Bohreromir self-assigned this Nov 12, 2026
@Bohreromir Bohreromir added this to Stackable Engineering Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.58% 9259 / 13699
🔵 Statements 66.52% 12443 / 18705
🔵 Functions 68.34% 2982 / 4363
🔵 Branches 57.47% 5214 / 9071
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/storage/modals/PreviewModal.svelte 74.35% 65.39% 80.19% 71.01% 152, 162, 164, 168, 180, 213-218, 262-264, 308, 339-350, 356, 432, 453-545, 549, 553-555, 563, 579-580, 599-615, 623-640, 646-647, 653, 673-701, 729-731, 755-759, 754, 769, 768, 728, 799, 841, 840, 837, 940-945, 952-953, 939, 1027-1024
Generated in workflow #1299 for commit 7221c29 by the Vitest Coverage Report Action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Bohreromir
fix(storage): Show the binary fallback for files the server marks as …
7221c29 
…not renderable

For content types in KNOWN_BINARY_TYPES the preview endpoint returns an
empty body with X-Preview-Renderable: false. The preview modal ignored
that header, decoded the empty body as valid UTF-8 and showed an empty,
read-only text editor instead of the binary fallback.

Check the header right after the 7z/rar checks and show the fallback.
The unit test mock now sends the real binaryPreview() headers, and an
E2E test covers an application/avro object.
@Bohreromir
Bohreromir force-pushed the fix/preview-binary-fallback branch from 4e7c408 to 7221c29 Compare November 12, 2026 14:21
@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Nov 12, 2026
@Bohreromir
Bohreromir marked this pull request as ready for review November 12, 2026 14:23
lfrancke
lfrancke approved these changes Nov 12, 2026
View reviewed changes
@lfrancke lfrancke moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lfrancke lfrancke lfrancke approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Bohreromir Bohreromir

Labels

None yet

Projects

Stackable Engineering
Status: Development: In Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Bohreromir @lfrancke
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.