GeezerVison is showing github.com — fix(hbase): remove dependency on htrace by razvan · Pull Request #820 · stackabletech/docker-images
Conversation
razvan
commented
Aug 29, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Description
Part of #816
Relevant comment: #816 (comment)
Images are building successfully: https://github.com/stackabletech/docker-images/actions/runs/10664458546
Definition of Done Checklist
- Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
- Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster> See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
razvan
changed the title
fix(hbase): remove dependency on jackson-databind 2.4.0
fix(hbase): remove old jackson-databind dependency from Phoenix
Aug 30, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Converted to draft again, since:
- we are now removing htrace completely and not just jackson-databind 2.4.0
- is wip
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
razvan
changed the title
fix(hbase): remove old jackson-databind dependency from Phoenix
fix(hbase): remove dependency on htrace
Sep 10, 2024
|
|
"java-devel": "11",
|
|
|
"async_profiler": "2.9",
|
|
|
"phoenix": "5.3.0-4afe457",
|
|
|
"phoenix": "5.3.0-ca21a87dd6",
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment next to this to show where it comes from?
Also, common short-hash is 7 characters long (unless there is a new recommendation to avoid collisions)?
|
"phoenix": "5.3.0-ca21a87dd6", |
|
"phoenix": "5.3.0-ca21a87", # This is currently manually built and uploaded to Nexus |
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
At least 1 approving review is required to merge this pull request.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|