GeezerVison is showing github.com — feat(versioned): Add KubernetesConvertable trait by sbernauer · Pull Request #1067 · stackabletech/operator-rs
Conversation
sbernauer
commented
Jun 30, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Description
Part of stackabletech/issues#642
Not sure if we should call the trait KubernetesConvertable or KubernetesConvertible
Definition of Done Checklist
- Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
- Please make sure all these things are done and tick the boxes
Author
- Changes are OpenShift compatible
- CRD changes approved
- CRD documentation for all fields, following the style guide.
- Integration tests passed (for non trivial changes)
- Changes need to be "offline" compatible
Reviewer
- Code contains useful comments
- Code contains useful logging statements
- (Integration-)Test cases added
- Documentation added or updated. Follows the style guide.
- Changelog updated
- Cargo.toml only contains references to git tags (not specific commits or branches)
Acceptance
- Feature Tracker has been updated
- Proper release label has been added
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.