GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(versioned): Allow any JSON value in tracked changed values by sbernauer · Pull Request #1326 · stackabletech/operator-rs

Conversation

@sbernauer

@sbernauer sbernauer commented Nov 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Description

Part of stackabletech/hive-operator#678

The CRD schema of ChangedValue's value and downgradedValue fields was type: object.
Tracked values can be any JSON value, though. A string like "/stackable/warehouse" made the status patch fail with "expected map".

Drop the type and only set x-kubernetes-preserve-unknown-fields, which Kubernetes allows for structural schemas. Also set nullable so null values aren't pruned by the apiserver.

Add the same helper as raw_any_nullable_value_schema to stackable-operator, so other code can use it.

I also fixed a crate path bug I ran into while adding the status to the CRD previewer.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
sbernauer added 2 commits November 6, 2026 13:38
@sbernauer
fix(versioned): Allow any JSON value in tracked changed values
7ebfd13
@sbernauer
test: Include in CRD preview and respect crate overrides
92d4847
@sbernauer
sbernauer requested a review from Techassi November 6, 2026 12:55
@sbernauer sbernauer mentioned this pull request Nov 6, 2026
fix(versioned): Make changedValues in tracking status optional #1325
Open
13 tasks
Techassi
Techassi requested changes Nov 9, 2026
View reviewed changes

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor nitpicks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread crates/stackable-versioned/CHANGELOG.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread crates/stackable-versioned-macros/src/codegen/container/struct/conversion.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread crates/stackable-versioned-macros/src/codegen/container/struct/conversion.rs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sbernauer sbernauer mentioned this pull request Nov 9, 2026
Support starting Iceberg REST catalog via CRD stackabletech/hive-operator#678
Open
9 tasks
sbernauer and others added 3 commits November 9, 2026 13:18
@sbernauer @Techassi
Apply batched suggestions from code review
9a51fa5
Co-authored-by: Techassi <[email protected]>
@sbernauer @Techassi
Update crates/stackable-versioned/CHANGELOG.md
a48665f
Co-authored-by: Techassi <[email protected]>
@sbernauer
Merge branch 'fix/versioned-optional-changed-values' into fix/version…
61e7f6f
…ed-any-changed-value-type
@sbernauer
sbernauer requested a review from Techassi November 9, 2026 12:20
Techassi
Techassi approved these changes Nov 9, 2026
View reviewed changes

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sbernauer @Techassi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.