GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: add space after data: sse_stream_generator by kantord · Pull Request #1087 · stacklok/codegate

This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@kantord

@kantord kantord commented Feb 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

for more context, see this discussion on discord: https://discord.com/channels/1184987096302239844/1336728608538099734/1341364487621705809

it's also related to #901

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kantord
fix: add space after data: sse_stream_generator
0309c3a
@kantord
kantord marked this pull request as ready for review February 18, 2025 11:41
jhrozek
jhrozek approved these changes Feb 18, 2025
View reviewed changes
@kantord
kantord merged commit cd3de72 into main Feb 18, 2025
@kantord
kantord deleted the fix-stream-data-space branch February 18, 2025 11:48
@kantord kantord mentioned this pull request Feb 18, 2025
fix: add space after "data:" in muxing adapter #1090
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jhrozek jhrozek jhrozek approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kantord @jhrozek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.