GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: add workspaces list endpoint by provider id by peppescg · Pull Request #1099 · stacklok/codegate

This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@peppescg

@peppescg peppescg commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

Added an endpoint /workspaces/:provider_id that return the list of workspaces by a provider id. This allow the dashboard to show the impacted workspaces in case of providers deletion. The dashboard will show a list of workspaces in the confirmation dialog before a provider will be deleted, in this way it is clear which workspaces are impacted.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
peppescg added 2 commits February 19, 2025 10:22
@peppescg
feat: add workspaces list endpoint by provider id
d0bd3d9
@peppescg
leftover
c4f3a9c
@peppescg peppescg self-assigned this Feb 19, 2025
aponcedeleonch
aponcedeleonch reviewed Feb 19, 2025
View reviewed changes

@aponcedeleonch aponcedeleonch left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/codegate/api/v1.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/codegate/api/v1.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@peppescg
refactor: simplify return values
0ee1ef4
aponcedeleonch
aponcedeleonch approved these changes Feb 19, 2025
View reviewed changes
@peppescg
peppescg merged commit 868c687 into main Feb 19, 2025
@peppescg
peppescg deleted the issues/1098 branch February 19, 2025 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@aponcedeleonch aponcedeleonch aponcedeleonch approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@peppescg peppescg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@peppescg @aponcedeleonch
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.