GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Switch usage of `re` package for `regex` which is slightly more performant by JAORMX · Pull Request #1127 · stacklok/codegate

This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@JAORMX

@JAORMX JAORMX commented Feb 20, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

regex is a drop-in replacement of re and provides better
performance.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JAORMX
JAORMX force-pushed the re-to-regex branch 2 times, most recently from 16a4011 to 6ea9af2 Compare February 20, 2025 13:29
@JAORMX
Switch usage of re package for regex which is slightly more perfo…
67cb826 
…rmant

`regex` is a drop-in replacement of `re` and provides better
performance.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX
JAORMX force-pushed the re-to-regex branch from 6ea9af2 to 67cb826 Compare February 20, 2025 13:34
@JAORMX
JAORMX requested review from aponcedeleonch, jhrozek and rdimitrov February 20, 2025 13:57
rdimitrov
rdimitrov approved these changes Feb 20, 2025
View reviewed changes
@JAORMX
JAORMX merged commit 1055216 into main Feb 20, 2025
@JAORMX
JAORMX deleted the re-to-regex branch February 20, 2025 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aponcedeleonch aponcedeleonch Awaiting requested review from aponcedeleonch
@jhrozek jhrozek Awaiting requested review from jhrozek
1 more reviewer
@rdimitrov rdimitrov rdimitrov approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JAORMX @rdimitrov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.