GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Strip attachments from copilot messages when handling the CLI commands by jhrozek · Pull Request #1202 · stacklok/codegate

This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@jhrozek

@jhrozek jhrozek commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Copilot sends files in the context in the following format:

<attachment>
file
<attachment>
user query

Fixes: #1061

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JAORMX
JAORMX previously approved these changes Mar 4, 2025
View reviewed changes
Comment thread src/codegate/pipeline/cli/cli.py Outdated
Returns:
Optional[re.Match[str]]: A regex match object if command is found, None otherwise
"""
cleaned_text = re.sub(r'<attachment>.*</attachment>', '', last_user_message_str, flags=re.DOTALL)

@JAORMX JAORMX Mar 4, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optimization: pre-declare and pre-compile each regular expression in the constructor or even globally so this function would only need to evaluate the regex as opposed to compile+evaluate.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jhrozek jhrozek Mar 4, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it separately for all the regexes here. We should also move the client helpers to the client interface.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jhrozek
Strip attachments from copilot messages when handling the CLI commands
3625d6d 
Copilot sends files in the context in the following format:
```
<attachment>
file
<attachment>
user query
```

Fixes: #1061
@jhrozek
jhrozek dismissed JAORMX’s stale review via 3625d6d March 4, 2025 13:27
@jhrozek
jhrozek force-pushed the copilot_version branch from e7db32e to 3625d6d Compare March 4, 2025 13:27
JAORMX
JAORMX approved these changes Mar 4, 2025
View reviewed changes
@jhrozek
jhrozek merged commit 08c0111 into main Mar 4, 2025
@jhrozek
jhrozek deleted the copilot_version branch March 4, 2025 20:02
@danbarr danbarr mentioned this pull request Mar 10, 2025
codegate cli doesn't work in copilot if context is selected #1061
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@JAORMX JAORMX JAORMX approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

codegate cli doesn't work in copilot if context is selected

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jhrozek @JAORMX
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.