GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix streaming output corruption with copilot by jhrozek · Pull Request #1261 · stacklok/codegate

This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@jhrozek

@jhrozek jhrozek commented Mar 10, 2025

Copy link
Copy Markdown
Contributor
  • Shortcut other steps if one holds the output - We had a bug in the output pipeline where if one step returned [] meaning that the output chunk should be held off, all the current chunks would continue to run and potentially modify the context.
  • Shortcut buffered PII sooner, as soon as the buffer can't be a UUID - Our PII refaction format is #UUID#. Our code was finding an opening #, then checking for a closing matching # or end of the output. For copilot, however, this meant that we were buffering the whole file, because the filename comes in this format:
# filepath: /Users/jakub/devel/demo-repo-python/app.py

This means we would keep searching for the closing hash which never
came. Instead, buffer only as long as the context between the hashes can
reasonably be a UUID.

Fixes: #1250

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jhrozek

jhrozek commented Mar 10, 2025

Copy link
Copy Markdown
Contributor Author

@blkt I can rebase this atop replace-litellm if you prefer

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JAORMX
JAORMX previously approved these changes Mar 11, 2025
View reviewed changes
jhrozek added 2 commits March 12, 2025 22:31
@jhrozek
Shortcut other steps if one holds the output
9362c50
We had a bug in the output pipeline where if one step returned []
meaning that the output chunk should be held off, all the current chunks
would continue to run and potentially modify the context.
@jhrozek
Shortcut buffered PII sooner, as soon as the buffer can't be a UUID
6d18876
Our PII refaction format is `#UUID#`. Our code was finding an opening #,
then checking for a closing matching # or end of the output. For
copilot, however, this meant that we were buffering the whole file,
because the filename comes in this format:

```
```

This means we would keep searching for the closing hash which never
came. Instead, buffer only as long as the context between the hashes can
reasonably be a UUID.

Fixes: #1250
@jhrozek
jhrozek dismissed JAORMX’s stale review via 6d18876 March 12, 2025 21:32
@jhrozek
jhrozek force-pushed the copilot_secrets_out_bug branch from 5380786 to 6d18876 Compare March 12, 2025 21:32
@jhrozek

jhrozek commented Mar 12, 2025

Copy link
Copy Markdown
Contributor Author

just rebased atop Rado's test fix

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lukehinds
Merge branch 'main' into copilot_secrets_out_bug
6e6af4e
JAORMX
JAORMX approved these changes Mar 14, 2025
View reviewed changes
@jhrozek
jhrozek merged commit de09cad into main Mar 14, 2025
@jhrozek
jhrozek deleted the copilot_secrets_out_bug branch March 14, 2025 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@JAORMX JAORMX JAORMX approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

codegate garbles output on main

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jhrozek @JAORMX @lukehinds
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.