GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove Ollama from Integration Tests by lukehinds · Pull Request #1376 · stacklok/codegate

This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@lukehinds

@lukehinds lukehinds commented Apr 28, 2025

Copy link
Copy Markdown

Need to test this by pushing

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lukehinds
Remove Ollama from Integration Tests
716cca7
rdimitrov
rdimitrov reviewed Apr 29, 2025
View reviewed changes
Comment thread tests/integration/integration_tests.py Outdated
Comment on lines +379 to +385
else:
selected_providers = available_providers

# Exclude ollama provider if it's in the list
if "ollama" in selected_providers:
selected_providers.remove("ollama")
logger.info("Excluded 'ollama' provider from tests.")

@rdimitrov rdimitrov Apr 29, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave that there as we might want to run the test locally.

The change in the workflow yml file should be sufficient to skip the ollama tests from running 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
blkt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
blkt
blkt previously approved these changes Apr 29, 2025
View reviewed changes
@rdimitrov

rdimitrov commented Apr 29, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@blkt @lukehinds - I see Michelangelo liked the suggestion so I hope you don't mind that I'll push on top of this PR to revert only that change so we can merge the rest
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rdimitrov
Leave the option to run ollama tests locally
725907e 
Signed-off-by: Radoslav Dimitrov <[email protected]>
@rdimitrov
rdimitrov dismissed blkt’s stale review via 725907e April 29, 2025 10:52
@rdimitrov
Merge branch 'main' into rem-ollama
dc828c2
@rdimitrov
rdimitrov requested a review from blkt April 29, 2025 10:52
blkt
blkt approved these changes Apr 29, 2025
View reviewed changes
@rdimitrov
rdimitrov merged commit 6bb71bf into main Apr 29, 2025
@rdimitrov
rdimitrov deleted the rem-ollama branch April 29, 2025 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@rdimitrov rdimitrov rdimitrov left review comments
@blkt blkt blkt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@lukehinds @rdimitrov @blkt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.