This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Conversation
longwave
commented
Jan 17, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Drupal uses stack/builder and so we need to add Symfony 6 compatibility here for us to be able to upgrade.
Locally the tests pass for me with these changes:
$ vendor/bin/phpunit
PHPUnit 9.5.11 by Sebastian Bergmann and contributors.
Warning: Your XML configuration validates against a deprecated schema.
Suggestion: Migrate your XML configuration using "--migrate-configuration"!
............... 15 / 15 (100%)
Time: 00:00.021, Memory: 8.00 MB
OK (15 tests, 22 assertions)
However the new return type in StackedHttpKernel::handle() might mean this has to be a 2.0 release?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
It has to be a 2.0 release indeed.
But I would strongly recommend stopping using this and replacing it with standard Symfony classes instead.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.