GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — migrate-embedded-sqlite-to-pure-go-modernc by jeffreyaven · Pull Request #786 · stackql/stackql Conversation
Member
DescriptionMigrates the embedded SQLite backend from cgo to pure Go. The embedded History. The original work order halted on a stop condition (the driver
Result: robot suite 651/651 PASS on User-visible behavior changes (documented in any-sdk Follow-up before release: bump go.mod to any-sdk Six commits in the three work-order groups: Type of change
Issues referenced.Resolves the unblocking request from this PR's original halt report via Evidence
Performance - cgo baseline from the last 10 successful
Checklist:
VariationsThe only test fixture modified is the Tech DebtRetired in this change set: the stackql-go-sqlite3 fork dependency and its
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions* docs(sqlfuncs): mirror CLAUDE.md as AGENTS.md for all agent sessions Co-authored-by: jeffreyaven <[email protected]> * deps: adopt any-sdk pure-Go sqlite backend, drop mattn/cgo fork replace Co-authored-by: jeffreyaven <[email protected]> * ci: retire cgo - CGO_ENABLED=0, drop C toolchains and sqlite_stackql tag, add per-artifact function smoke Co-authored-by: jeffreyaven <[email protected]> * docs+test: modernc backend invariants, release notes draft, robot ext-function smoke scenario Co-authored-by: jeffreyaven <[email protected]> * deps: bump any-sdk to alpha02 (aws_policy_equal tags parity, boolean decltype); pin sqlite_version fixture to 3.53.4 Co-authored-by: jeffreyaven <[email protected]> * burn: remove executed migration work order Co-authored-by: jeffreyaven <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jeffreyaven <[email protected]> * retire remaining cgo configuration and stale migration artifacts Co-authored-by: jeffreyaven <[email protected]> * preserve migration smoke-test documentation Co-authored-by: jeffreyaven <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jeffreyaven <[email protected]> Co-authored-by: jeffreyaven <[email protected]> Co-authored-by: jeffreyaven <[email protected]>
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. filename should not have spaces ideally please change to
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed to Also updated the three references to the old name so nothing is left dangling: the header comments in
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move this to robot
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done in 27f1c4d. The step is removed; the check is the robot scenario The scenario previously used a weaker
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. move this to robot
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed in 27f1c4d, with one thing to flag. This job has no robot harness: no checkout and no Python, it only downloads the amd64 exe from If you want emulation coverage kept, the options are wiring a minimal robot run into this job, or keeping a workflow-level check in this job only. Let me know which you prefer and I will add it. I also dropped the stale "cgo" wording from the comment just above, since this PR makes it incorrect.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. move this to robot
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed in 27f1c4d.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. move this to robot
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed in 27f1c4d. This job runs the functional suite in-job, so the robot scenario
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. move this to robot
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed in 27f1c4d. This job runs the functional suite in-job, so the robot scenario
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. move this to robot
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed in 27f1c4d, with the same flag as on the This job builds and uploads the darwin arm64 binary but does not run robot, so after this change the extension functions are not exercised on darwin arm64. macOS coverage comes from Adding a full robot run here would take this job from roughly 3 minutes to something like the 30 minutes of the intel job, so I have not done that unprompted. Let me know if you want it.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This requires an assertion, at the conclusion of all shards, that every single test is run on each db and platform. Failure to verify both the total count and the presence of any expected line item must fail
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added in c645a2b as a new How it works:
Testing: run locally against real Scoping notes:
This has not run in CI yet. The artifact upload and download directory layout is the one part I could not exercise locally, so the first run on this push is the real test of it.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsRename `docs/stackql release process.md` to `docs/stackql_release_process.md` per review, and update the three references to it (two workflow header comments and the mcpb packaging notes) so nothing points at the old name. Co-Authored-By: Claude Fable 5.1 <[email protected]> Remove the six workflow-level extension function smoke steps from build.yml per review. The check lives in the robot scenario `Sqlite Extension Functions Smoke Working`, which now carries the stronger aws_policy_equal comparison the workflow steps used (Version plus scalar-vs-array Resource), so nothing is lost in the move. The scenario runs wherever the functional suite runs: winbuild, linuxtest, linuxarmbuild, macosbuild, wsltest and the docker sqlite leg. winarmsmoke and macosarmbuild have no robot harness, so the check is no longer exercised in those two jobs. Also drop the stale "cgo" wording from the winarmsmoke comment. Co-Authored-By: Claude Fable 5.1 <[email protected]> Sharding splits one robot run across several dockertest legs, so no single leg can attest that the whole suite ran. Add a dockertestverify job that runs once all legs conclude and fails unless, for each (platform, db backend) group, the shards together account for every functional test exactly once. - Each robot-running dockertest leg uploads its output.xml; unsharded legs upload as shard 1 of 1. - robot_shard.py gains a verifier. The expected tests are parsed from test/robot/functional with no shard modifier applied, then compared as a multiset against the union of the shard reports, so the total count and each individual test are checked independently. - Anything that prevents verification fails it: absent shard, absent output.xml, inconsistent shard counts, a NOT RUN test, an expected group with no reports, or reports from a group that is not listed. - dockermerge now needs dockertestverify, so an image cannot be pushed past a failed verification. Co-Authored-By: Claude Fable 5.1 <[email protected]> Per review: now that GitHub hosts arm64 macOS and Windows runners, run the robot functional suite on both rather than leaving the extension function check unexercised there. - macosarmbuild: mirror the macosbuild robot harness (libpq, python deps, registry rewrite, certificates, robot run, report upload). The libpq path is resolved with `brew --prefix` because homebrew's prefix differs on Apple Silicon. - winarmsmoke: mirror the winbuild robot harness against the amd64 binary under x64 emulation. Python is x64 because psycopg2-binary, psycopg-binary and cryptography publish no win_arm64 wheels. The job now checks out the repo (before the artifact downloads, since checkout cleans the workspace) and moves from the short to the standard job timeout. - winbuild: upload the MCP client as an artifact so the MCP scenarios run in winarmsmoke rather than being skipped. Co-Authored-By: Claude Fable 5.1 <[email protected]>
general-kroll-4-life
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |