GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ROX-23284: fix suspicious logs by dhaus67 · Pull Request #11199 · stackrox/stackrox

Conversation

@dhaus67

@dhaus67 dhaus67 commented May 21, 2024

Copy link
Copy Markdown
Contributor

Description

This PR fixes two things: ensure we use quay.io images instead of docker.io images since they are suspectible to rate limiting, extend the allow list pattern for suspicious logs to also cover more errors related to image enrichment.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Here I tell how I validated my change

  • see CI pass.

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dhaus67
ROX-23284: fix suspicious logs
9ba4c58
@rhacs-bot

rhacs-bot commented May 21, 2024

Copy link
Copy Markdown
Contributor

Images are ready for the commit at 9ba4c58.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-739-g9ba4c585ac.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@openshift-ci

openshift-ci Bot commented May 21, 2024

Copy link
Copy Markdown

@dhaus67: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-scanner-v4-tests 9ba4c58 link false /test ocp-4-12-scanner-v4-tests
ci/prow/ocp-4-15-scanner-v4-tests 9ba4c58 link false /test ocp-4-15-scanner-v4-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dhaus67
dhaus67 requested a review from janisz May 22, 2024 01:31
janisz
janisz approved these changes May 22, 2024
View reviewed changes
@dhaus67
dhaus67 merged commit 446eb68 into master May 22, 2024
@dhaus67
dhaus67 deleted the dh/05-21-rox-23284_fix_suspicious_logs branch May 22, 2024 12:35
@vikin91 vikin91 mentioned this pull request Nov 12, 2026
fix(ci): escape parentheses in HTTP log exceptions #24037
Open
4 of 9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@dhaus67 @rhacs-bot @janisz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.