GeezerVison

Summary by CodeRabbit

• Bug Fixes
  • Authentication provider URLs saved without an explicit port now remain portless instead of gaining :443.
  • Existing entries that already include :443 retain it when saved unchanged. Remove the port from an affected entry to change it; declarative configuration reflects the update during its next reconciliation.
• Documentation
  • Clarified how authentication provider URLs without an explicit port are handled.

Auth provider UI endpoint normalization no longer adds port 443 when an endpoint has no port. Tests, endpoint documentation, and the changelog reflect this behavior.

Changes: Auth Provider Endpoint Normalization

Layer / File(s)	Summary
Preserve endpoints without ports pkg/auth/authproviders/util.go, pkg/auth/authproviders/util_test.go, central/authprovider/service/service_impl_test.go	NormalizeUIEndpoint no longer adds port 443 when an endpoint has no port. Tests cover hostnames, IP addresses, IPv6 addresses, schemes, paths, trailing colons, and explicit ports.
Update endpoint expectations and documentation pkg/declarativeconfig/auth_provider.go, pkg/declarativeconfig/transform/auth_provider_test.go, proto/storage/auth_provider.proto, CHANGELOG.md	Declarative configuration and storage documentation state that endpoints can remain without a port. The transformation test and changelog reflect the behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to cac25

This change stops adding a default port to auth provider endpoints that have none, so OIDC and SAML callback URLs match again. No actionable merge-blocking risk remains. Existing providers saved with :443 keep it until an admin removes it and saves, and the changelog documents this.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "ROX-37916: Keep UI endpoints without a port as given" matches the main change. The PR stops NormalizeUIEndpoint from adding a default :443 port to auth provider UI endpoints, so endpoints e…
Description check		The description covers the problem, the fix, the upgrade behavior for providers saved on 5.0.0, and the validation steps. It follows the template's sections for user-facing documentation, testing and …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "ROX-37916: Keep UI endpoints without a port as given" matches the main change. The PR stops NormalizeUIEndpoint from adding a default :443 port to auth provider UI endpoints, so endpoints entered without a port are stored without one. The title is specific and short, and it names the ticket.

Full details: Description check

Explanation

The description covers the problem, the fix, the upgrade behavior for providers saved on 5.0.0, and the validation steps. It follows the template's sections for user-facing documentation, testing and quality, and validation. Several template items remain unchecked, including CI inspection and the unit, e2e, regression, and compatibility test boxes. The template's 'change me!' placeholder under Description and under 'How I validated my change' appears to have been replaced with real content. The description does not give an explicit test-coverage rationale beyond modified existing tests, but it names the go test packages that pass. The description is mostly complete, so it passes.

@@            Coverage Diff             @@
##           master   #24016      +/-   ##
==========================================
+ Coverage   52.67%   52.86%   +0.19%     
==========================================
  Files        2815     2755      -60     
  Lines      177441   175279    -2162     
==========================================
- Hits        93459    92654     -805     
+ Misses      75811    74538    -1273     
+ Partials     8171     8087      -84     

Flags with carried forward coverage won't be shown. Click here to find out more.

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.