GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ROX-37938: [Backport] Drop always-on 4.10+ sensor capability checks by clickboo · Pull Request #24025 · stackrox/stackrox

Conversation

@clickboo

@clickboo clickboo commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Description

Manual backport of #23933 to release-4.10.

Central no longer branches on always-on 4.10+ sensor capabilities:

  • SensorDetectionCap — always sync policies and process/network baselines
  • PullTelemetryDataCap / PullMetricsCap — always pull diagnostics telemetry and metrics
  • HealthMonitoringCap — rely on the cluster health pipeline for active sensors
  • NetworkGraphExternalSrcsCap — always push custom external network entities
  • AuditLogEventsCap — always sync audit log file state
  • SendDeduperStateOnReconnect — always send hash/deduper state; Sensor still honors Central's SendDeduperState preference

SensorACKSupport stays gated.

Scan-config sync on this branch still uses GetCluster, so the connection test expects three GetCluster calls. Master checks existence with Exists. The deduper-state assertion keeps this file's hash copy loop.

This change was partially generated by AI.

User-facing documentation

  • CHANGELOG.md is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

Updated Central connection tests that previously mocked missing wave-2 capabilities. Diagnostics tests no longer stub HasCapability for telemetry/metrics pull.

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI only

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@clickboo @cursoragent
ROX-37938: Drop always-on 4.10+ sensor capability checks (#23933)
1fb096c 
Co-authored-by: Cursor <[email protected]>
@clickboo clickboo added area/central area/sensor backport PR to backport changes from master to release branch ai-assisted labels Nov 12, 2026
@openshift-ci

openshift-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress label Nov 12, 2026
@github-actions github-actions Bot added the ai-review label Nov 12, 2026
@clickboo
clickboo requested review from guzalv and lvalerom November 12, 2026 02:58
@clickboo
clickboo marked this pull request as ready for review November 12, 2026 02:59
@clickboo
clickboo requested a review from a team as a code owner November 12, 2026 02:59
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress label Nov 12, 2026
@rhacs-bot

rhacs-bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Images are ready for the commit at 1fb096c.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.12-rc.0-8-g1fb096ccbf.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 48.14815% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.53%. Comparing base (631c214) to head (1fb096c).

Files with missing lines Patch % Lines
...ntral/sensor/service/connection/connection_impl.go 45.09% 18 Missing and 10 partials ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-4.10   #24025      +/-   ##
================================================
+ Coverage         49.51%   49.53%   +0.02%     
================================================
  Files              2663     2663              
  Lines            201394   201356      -38     
================================================
+ Hits              99725    99748      +23     
+ Misses            94212    94144      -68     
- Partials           7457     7464       +7
Flag Coverage Δ
go-unit-tests 49.53% <48.14%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@clickboo

clickboo commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

/test gke-qa-e2e-tests
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@clickboo

clickboo commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

/test gke-ui-e2e-tests
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vjwilson
vjwilson approved these changes Nov 12, 2026
View reviewed changes
@vjwilson
vjwilson merged commit 98044c4 into release-4.10 Nov 12, 2026
111 of 119 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vjwilson
vjwilson deleted the backport-23933-to-release-4.10 branch November 12, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vjwilson vjwilson vjwilson approved these changes
@lvalerom lvalerom Awaiting requested review from lvalerom
@guzalv guzalv Awaiting requested review from guzalv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ai-assisted ai-review area/central area/sensor backport PR to backport changes from master to release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@clickboo @rhacs-bot @vjwilson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.