GeezerVison

Summary by CodeRabbit

• New Features
  • Newly created policies are assigned an ID automatically.
• Bug Fixes
  • Policy updates with no effective changes no longer trigger unnecessary writes.
  • Changes to evaluation filters are recognized and applied.
  • Failed policy activation or synchronization can be retried, including when an update has no effective changes.
  • Policy creation and updates handle missing policies, lookup failures, and invalid submissions appropriately.

Policy upserts compare requests with stored policies after normalizing server-managed fields and evaluation filters. The service skips persistence for equivalent policies and tracks pending downstream updates until active-policy registration and sensor synchronization succeed.

Changes: Policy Upsert

Layer / File(s)	Summary
Upsert and propagation flow central/policy/service/service_impl.go	The service assigns UUIDs to creates and compares updates with stored policies. It skips persistence for equivalent policies when no propagation is pending. Attempt tokens track pending propagation and persistence failures.
Upsert behavior tests central/policy/service/service_impl_test.go	Tests cover policy comparisons, changed fields, persistence and propagation failures, retries, concurrency, creation, lookup errors, and invalid input.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: dashrews78, c-du

Merge Risk: Moderate · up to 4cbe3

Two concurrent updates to the same policy can leave detection enforcing an older version than the stored policy, and retrying the update does not repair it. The trigger needs overlapping updates to one policy, so it is uncommon, but it should be fixed or explicitly accepted before merge.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "fix(policy): skip unchanged policy updates" names the main change: policy updates whose content matches the stored policy are no longer written or broadcast. The raw summary and PR objectiv…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The description covers the core change: skipping unchanged policy upserts, keeping failed propagation retryable, and assigning IDs before persistence. It also lists tests and validation commands. Howe…

Full details: Title check

Explanation

The title "fix(policy): skip unchanged policy updates" names the main change: policy updates whose content matches the stored policy are no longer written or broadcast. The raw summary and PR objectives both center on this behavior. The title is concise, uses a conventional commit prefix, and does not list files. It omits the retry and propagation tracking that the change also adds, but the description does not require the title to cover every detail.

Full details: Description check

Explanation

The description covers the core change: skipping unchanged policy upserts, keeping failed propagation retryable, and assigning IDs before persistence. It also lists tests and validation commands. However, the template's required sections are incomplete. The '## Description' section retains the template placeholder context only partially, the CHANGELOG and documentation checkboxes are ticked without linking anything, the CI results checkbox is unticked, and the 'How I validated' section gives test and command results that are mostly complete. The description is mostly complete, so the check passes.

@@            Coverage Diff             @@
##           master   #24040      +/-   ##
==========================================
- Coverage   52.90%   52.87%   -0.04%     
==========================================
  Files        2755     2755              
  Lines      175277   175310      +33     
==========================================
- Hits        92732    92696      -36     
- Misses      74479    74531      +52     
- Partials     8066     8083      +17     

Flags with carried forward coverage won't be shown. Click here to find out more.

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.