GeezerVison

Summary by CodeRabbit

• Bug Fixes
  • Permission-set, access-scope, and role checks continue to report when an ID or name is already in use, while preserving storage errors. These checks now rely on direct existence results rather than retrieving the full record, with no change to the reported outcomes.

The role store interfaces and mocks add Exists methods. Three datastore checks use store existence methods instead of fetching full objects with Get.

Changes: Role Existence Checks

Layer / File(s)	Summary
Store existence contracts central/role/store/store.go, central/role/store/mocks/store.go	PermissionSetStore and RoleStore add Exists methods. Their generated mocks and recorders add matching methods.
Datastore existence checks central/role/datastore/datastore_impl.go	Permission-set ID, access-scope ID, and role-name checks use Exists instead of Get. Storage errors continue to pass through, and existing keys still return AlreadyExists.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Merge Risk: Minimal · up to 7621e

The change replaces full-object reads with existence checks in role and access-scope validation. Duplicate detection and error behavior are described as unchanged. No actionable merge risk was identified.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main change: role, permission-set and access-scope uniqueness validators switch from full-object Get calls to Exists checks. It matches the summary and objectives, and it is specif…
Description check		The description covers the change, the new Exists declarations, the unchanged AlreadyExists behavior, and the validation commands. It follows the template structure with the User-facing documentation …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: role, permission-set and access-scope uniqueness validators switch from full-object Get calls to Exists checks. It matches the summary and objectives, and it is specific and concise.

Full details: Description check

Explanation

The description covers the change, the new Exists declarations, the unchanged AlreadyExists behavior, and the validation commands. It follows the template structure with the User-facing documentation and Testing sections. Some items remain unchecked: CI results are not inspected, and no unit, e2e, regression, compatibility, or modified-test items are checked. The author gives a reason for adding no new tests, which the template accepts. The Testing and quality and Automated testing sections need the author to confirm CI status and state the test rationale more directly. The template's 'change me!' placeholders are replaced. The description is mostly complete.

@@            Coverage Diff             @@
##           master   #24042      +/-   ##
==========================================
- Coverage   52.90%   52.86%   -0.05%     
==========================================
  Files        2755     2755              
  Lines      175277   175277              
==========================================
- Hits        92732    92654      -78     
- Misses      74479    74537      +58     
- Partials     8066     8086      +20     

Flags with carried forward coverage won't be shown. Click here to find out more.

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.