GeezerVison

Summary by CodeRabbit

• New Features
  • Successful base image additions and edits now display dismissible toast notifications.
  • Reopening the modal after a successful save shows the form without an inline success alert. Error alerts remain unchanged.

Base image saves now pass success messages from the modal to the page. The page closes the modal, displays the message as a toast, and refetches base images. The modal resets mutation state and no longer renders its own success alert.

Changes: Base image success notification flow

Layer / File(s)	Summary
Modal success handoff and reset ui/apps/platform/src/Containers/BaseImages/BaseImagesModal.tsx	The success callback now accepts a message. Successful add and edit operations reset mutation state and pass a mode-specific message to the parent. The modal no longer renders a success alert.
Page toast flow and modal tests ui/apps/platform/src/Containers/BaseImages/BaseImagesPage.tsx, ui/apps/platform/src/Containers/BaseImages/BaseImagesModal.cy.jsx	The page closes the modal, queues the success message as a toast, and refetches base images. Tests verify the callback message and confirm the form is available after reopening without an inline success alert.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant BaseImagesModal
  participant BaseImagesPage
  participant AlertGroup
  User->>BaseImagesModal: Save base image
  BaseImagesModal->>BaseImagesPage: onSuccess(successMessage)
  BaseImagesPage->>BaseImagesPage: Close modal, queue toast, refetch base images
  BaseImagesPage->>AlertGroup: Render queued toast
  User->>AlertGroup: Dismiss toast
  AlertGroup->>BaseImagesPage: Remove toast

Loading

Suggested reviewers: alanonthegit

Merge Risk: Minimal · up to 86b4e

Base image add and edit successes now appear as toasts instead of a stale inline alert after reopening the modal. No actionable merge-blocking risk remains.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the ticket and the main change: base image save success is now shown as a toast instead of an inline alert in the modal. It matches the changeset, which removes the inline success aler…
Description check		The description follows the repository template. It explains the root cause (a stale inline success alert shown after reopening the dialog), the fix in BaseImagesModal and BaseImagesPage, and alternat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the ticket and the main change: base image save success is now shown as a toast instead of an inline alert in the modal. It matches the changeset, which removes the inline success alert from BaseImagesModal, passes the message to BaseImagesPage through onSuccess, and renders it as a toast. The title is specific and concise.

Full details: Description check

Explanation

The description follows the repository template. It explains the root cause (a stale inline success alert shown after reopening the dialog), the fix in BaseImagesModal and BaseImagesPage, and alternatives considered. It also includes the user-facing documentation and testing checklists, and it describes concrete validation: the Cypress test changes, the local page-level check, and the tsc, ESLint, Prettier, and Vitest runs. Several template items remain unchecked: CI results are not inspected, and unit tests and e2e tests are not marked as added. The e2e test was not run locally. The 'change me!' placeholders were replaced. The description is mostly complete, so the check passes.

@@            Coverage Diff             @@
##           master   #24045      +/-   ##
==========================================
- Coverage   52.90%   52.86%   -0.05%     
==========================================
  Files        2755     2755              
  Lines      175277   175277              
==========================================
- Hits        92732    92654      -78     
- Misses      74479    74537      +58     
- Partials     8066     8086      +20     

Flags with carried forward coverage won't be shown. Click here to find out more.

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.