GeezerVison

Summary by CodeRabbit

• New Features
  • Deployment and vulnerability report CSVs now include a Container Name column, making it easier to distinguish containers that use the same image.
  • Rows without a deployment show an empty container name. Container names are also retained with deployment records so they can appear in reports.

Deployment container names are now persisted and selected for image CVE reports. CSV reports include a “Container Name” column. Rows have an empty value when the response has no container name.

Changes: Container Name Reporting

Layer / File(s)	Summary
Persist and select container names proto/storage/deployment.proto, pkg/postgres/schema/deployments.go, pkg/search/options.go, central/deployment/datastore/internal/store/postgres/store.go, pkg/search/postgres/common_test.go	The deployment container model and storage paths include names. Search metadata labels the name field, and a query test checks its selection and join.
Select names for report responses central/reports/scheduler/v2/reportgenerator/report_gen_impl.go, central/reports/scheduler/v2/reportgenerator/types.go, central/reports/scheduler/v2/reportgenerator/report_gen_view_based_test.go, central/reports/scheduler/v2/reportgenerator/report_gen_transaction_integration_test.go	The deployed-image query selects container names. Report responses expose a nullable name and an accessor that returns an empty string when the name is nil. Integration tests check responses for shared images and deployed rows.
Include names in CSV output central/reports/scheduler/v2/reportgenerator/csv_gen.go, central/reports/scheduler/v2/reportgenerator/csv_gen_test.go	CSV headers and rows include container names. Tests cover populated names and empty values with KEV enabled and disabled.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant ReportQuery
  participant ImageCVEQueryResponse
  participant GenerateCSV
  ReportQuery->>ImageCVEQueryResponse: select deployment container name
  ImageCVEQueryResponse->>GenerateCSV: provide container name

Loading

Suggested reviewers: ksurabhi91, dashrews78

Merge Risk: Minimal · up to da37c

The change adds a Container Name column to image vulnerability CSV reports and keeps one row per affected container. No merge-blocking risk was identified. Existing deployments may show a blank container name until they are updated.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "ROX-37837: Identify affected containers in reports" matches the main change. The PR keeps one CVE row per affected container and adds a Container Name column to image vulnerability CSV repo…
Description check		The description covers the problem, the fix (one row per container and a new Container Name CSV column), and a note that existing deployments need an update or a separate backfill. It fills the user-f…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "ROX-37837: Identify affected containers in reports" matches the main change. The PR keeps one CVE row per affected container and adds a Container Name column to image vulnerability CSV reports. The title is concise and specific, and it includes the ticket ID, which is acceptable.

Full details: Description check

Explanation

The description covers the problem, the fix (one row per container and a new Container Name CSV column), and a note that existing deployments need an update or a separate backfill. It fills the user-facing documentation and testing checklists. It also gives a concrete validation on GKE with two containers sharing one image, with row counts and sample values. The template's unchecked e2e and compatibility test boxes are left unchecked, which is acceptable. The template's placeholder text 'change me!' was replaced in the Description section, but the 'How I validated' section and the description body are otherwise complete.

@@            Coverage Diff             @@
##           master   #24046      +/-   ##
==========================================
- Coverage   52.90%   52.86%   -0.05%     
==========================================
  Files        2755     2755              
  Lines      175277   175286       +9     
==========================================
- Hits        92732    92665      -67     
- Misses      74479    74533      +54     
- Partials     8066     8088      +22     

Flags with carried forward coverage won't be shown. Click here to find out more.

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.