GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — We seem to use `npm test`, not `gulp test` by mattwynne · Pull Request #63 · stacktracejs/error-stack-parser

Conversation

@mattwynne

@mattwynne mattwynne commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

Description

Change contributing docs to use npm test not gulp test

Motivation and Context

I wanted to contribute, and when I followed this step I got an error. Not even npx gulp test worked, and there's no gulpfile here, so I figured this step was out of date.

Checklist:

  • npm test passes without errors
  • I have read the contribution guidelines
  • I have updated the documentation accordingly

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mattwynne
We seem to use npm test, not gulp test
86089a3
@eriwen

eriwen commented Oct 14, 2021

Copy link
Copy Markdown
Member

Thanks for the contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriwen
eriwen merged commit abe34a7 into stacktracejs:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mattwynne @eriwen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.