GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Re-export StackFrame type for backwards compatibility by andersk · Pull Request #72 · stacktracejs/error-stack-parser

Conversation

@andersk

@andersk andersk commented Feb 12, 2022

Copy link
Copy Markdown
Contributor

Description

2.0.7 removed a mis-matching export of StackFrame (#54), but some users were relying on it. Re-export the correct one.

Motivation and Context

#54 (comment)

How Has This Been Tested?

tsc error-stack-parser.d.ts

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • node_modules/.bin/jscs -c .jscsrc error-stack-parser.js passes without errors
    • (You removed jscs in f5184d7.)
  • npm test passes without errors
  • I have read the contribution guidelines
    • (FYI, this is a broken link when you actually open a PR.)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dotlambda reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@andersk
Re-export StackFrame type for backwards compatibility
313ffe1 
Signed-off-by: Anders Kaseorg <[email protected]>
andersk referenced this pull request Feb 12, 2022
@andersk
Import the TypeScript definition for StackFrame from stackframe
ce729ee 
The slight incompatibility of the old definition was necessitating
unsafe casts between ErrorStackParser.StackFrame and StackFrame.

Signed-off-by: Anders Kaseorg <[email protected]>
@eriwen eriwen self-assigned this Jun 5, 2022
@eriwen
eriwen merged commit 1f7562c into stacktracejs:master Jun 5, 2022
@eriwen

eriwen commented Jun 5, 2022

Copy link
Copy Markdown
Member

Thanks for the PR @andersk!

I'd like to prevent these kinds of regressions using automated checks. Do you have any recommendations (GitHub actions or npm scripts) to do this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RenateM
RenateM reviewed Jun 7, 2022
View reviewed changes

@RenateM RenateM left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit seems to be causing our builds to fail with the following error:
ERROR in node_modules/error-stack-parser/error-stack-parser.d.ts:9:5 - error TS1128: Declaration or statement expected.
9 export type {StackFrame};
~~~~~~
node_modules/error-stack-parser/error-stack-parser.d.ts:9:17 - error TS1005: ';' expected.
9 export type {StackFrame};
~

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kristian-atanasov reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@andersk
andersk deleted the re-export-StackFrame branch June 8, 2022 00:14
@andersk

andersk commented Jun 8, 2022

Copy link
Copy Markdown
Contributor Author

@RenateM It sounds like you have a very old version of TypeScript. Make sure you’ve upgraded to at least 3.8 (latest: 4.7.3).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@RenateM RenateM RenateM left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@eriwen eriwen

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@andersk @eriwen @RenateM
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.