GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Rewrite toString to match Node internals by niftylettuce · Pull Request #23 · stacktracejs/stackframe

Conversation

@niftylettuce

@niftylettuce niftylettuce commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

This closes #21 and #22, and rewrites the toString method to output a stack trace format that more closely resembles Node internals.

Ref: https://github.com/nodejs/node/blob/b6bfc193788b1838bee73d584fe089e1104b9f88/src/node_errors.cc#L142-L175

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@niftylettuce
Rewrite toString to match Node internals
dcb6417
@niftylettuce

niftylettuce commented Sep 13, 2019

Copy link
Copy Markdown
Contributor Author

The travis build failed due to an apt-get install failure of google-chrome (not related to this code).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
niftylettuce added 2 commits September 13, 2019 07:23
@niftylettuce
Fixed toString issue with prefixed " at "
1503a03
@niftylettuce
Fixed this.isEval to this.getIsEval
c155969
@niftylettuce

niftylettuce commented Sep 13, 2019

Copy link
Copy Markdown
Contributor Author

I've tested this on my end, all is fixed and ready for merge!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@niftylettuce niftylettuce mentioned this pull request Sep 13, 2019
How to get the "stack trace" string? stacktracejs/stacktrace.js#147
Closed
niftylettuce added 5 commits September 13, 2019 08:55
@niftylettuce
Fixed tests
a94646b
@niftylettuce
Added dist to gitignore (closes #24)
691fb8c
@niftylettuce
Fix trusty > xenial per <https://travis-ci.community/t/travis-is-down…
87cdab5 
…loading-older-chrome-versions-in-place-of-chrome-stable/5040/4>
@niftylettuce
fix: fixed xvfb
67715cc
@niftylettuce
fix: set travis to v8
c772aa8
@eriwen eriwen self-assigned this Sep 14, 2019
@eriwen eriwen added the a:feature label Sep 14, 2019
@eriwen
eriwen merged commit 1352264 into stacktracejs:master Sep 14, 2019
@eriwen eriwen mentioned this pull request Sep 14, 2019
toString does not match V8 stack trace format #22
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@eriwen eriwen

Labels

a:feature

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Given an array of stack frames, convert to V8 stack trace stack prop

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@niftylettuce @eriwen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.