GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — TypeScript definition fixes by andersk · Pull Request #27 · stacktracejs/stackframe

Conversation

@andersk

@andersk andersk commented Oct 30, 2019

Copy link
Copy Markdown
Contributor
  • Fix export structure
  • Getters may return undefined
  • Add data members

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andersk andersk mentioned this pull request Oct 30, 2019
Fix typo in TypeScript definitions: TopLevel → Toplevel stacktracejs/error-stack-parser#49
Merged
andersk added 3 commits October 30, 2019 19:32
@andersk
TypeScript definition: Fix export structure
7d4bb8b 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
TypeScript definition: Getters may return undefined
38359c9 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
TypeScript definition: Add data members
7eb5edf 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
andersk force-pushed the typescript branch from f18a237 to 7eb5edf Compare October 31, 2019 02:33
eriwen
eriwen approved these changes Jan 5, 2020
View reviewed changes
@eriwen
eriwen merged commit 030fe14 into stacktracejs:master Jan 5, 2020
@eriwen

eriwen commented Jan 5, 2020

Copy link
Copy Markdown
Member

Thanks for your improvements @andersk!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriwen eriwen eriwen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@andersk @eriwen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.