GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — Python3 port of SCL library by devonsparks · Pull Request #408 · stepcode/stepcode Conversation
Contributor
MotivationI've been using the Py2 SCL library in the stepcode library to good effect for some IFC experiments. I now would like to integrate this with adjacent libraries that have a Py3 dependency. Considering Python2 is sunset, and there's interest (Issue 407) from the stepcode community in a Py3 port, it seemed like a good time to start. This PR is the result. Summary of ChangesChanges fell in two categories:
Changes on (1) were minor (updating the use of the new Changes on (2) were more significant. They include:
The only "breaking change" is a test case file, ValidationI'm able to successfully build the package (
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsIncludes: - Updating core to remove Py2 dependencies (especially print_function) - Migrating setup.py to setup.cfg to support integration with PyPA build - Making all imports absolute - Fixing the test suite to ensure it runs again (with the exception of unitary schema, which seems to depend on modules that no longer exist) … into a package to support use with unittest. Added new sanity test for Part 21 parser.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
cshorler
self-requested a review
cshorler
reviewed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agree with @tpaviot - no need for inheriting object in Python 3. Also, we can use relative imports for library imports. I'll rebase and rework locally today or tomorrow.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Merged
Member
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |