GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Aachen Turbine Tutorial by alecappiello · Pull Request #56 · su2code/Tutorials

Conversation

@alecappiello

@alecappiello alecappiello commented Dec 17, 2024

Copy link
Copy Markdown

config and mesh files for the Aachen Turbine tutorial

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
alecappiello added 3 commits December 6, 2024 15:39
@alecappiello
mesh and config files
392c7c7
@alecappiello
right config files
5291cac
@alecappiello
right mesh file name
c6b9200
@alecappiello

alecappiello commented Dec 17, 2024

Copy link
Copy Markdown
Author

@joshkellyjak, could you review this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alecappiello

alecappiello commented Jan 15, 2025

Copy link
Copy Markdown
Author

@joshkellyjak, could you review this PR?

Hey Josh, could you have a look at this, so that we can finally close it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pcarruscag
pcarruscag reviewed Jan 15, 2025
View reviewed changes

@pcarruscag pcarruscag left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a copy of the test in TestCases?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@alecappiello

alecappiello commented Jan 16, 2025

Copy link
Copy Markdown
Author

Is this a copy of the test in TestCases?

Hi Pedro, the mesh is the same
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pcarruscag

pcarruscag commented Jan 16, 2025

Copy link
Copy Markdown
Member

Then can we put this case in the tutorials.py regression and remove the one from TestCases?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joshkellyjak
joshkellyjak reviewed Jan 16, 2025
View reviewed changes

@joshkellyjak joshkellyjak left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that this should be run as a regression test also

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread compressible_flow/Aachen_Turbine/Aachen_Turbine.cfg Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread compressible_flow/Aachen_Turbine/Aachen_Turbine.cfg
VISCOSITY_MODEL= SUTHERLAND
%
% Molecular Viscosity that would be constant (1.716E-5 by default)
MU_CONSTANT= 1.716E-5

@joshkellyjak joshkellyjak Jan 16, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this does anything so maybe best to remove it to avoid confusing between this and MU_REF

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@alecappiello alecappiello Feb 7, 2025

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that it works, I would avoid keep changing, just not to find out later that we missed something, as happened for the entropy fix in combination with JST.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread compressible_flow/Aachen_Turbine/Aachen_Turbine.cfg Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread compressible_flow/Aachen_Turbine/Aachen_Turbine.cfg
%
JST_SENSOR_COEFF= ( 0.5, 0.25 )
% Spatial numerical order integration
MUSCL_FLOW= NO

@joshkellyjak joshkellyjak Jan 16, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this option too

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@alecappiello alecappiello Feb 7, 2025

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer keeping it, so that new users become aware of it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread compressible_flow/Aachen_Turbine/Aachen_Turbine.cfg Resolved

Uh oh!

There was an error while loading. Please reload this page.
@alecappiello
cleaning the config file from useless entries
95bf820
@alecappiello

alecappiello commented Feb 7, 2025

Copy link
Copy Markdown
Author

Then can we put this case in the tutorials.py regression and remove the one from TestCases?

Do you mean using this mesh in the tutorial files also for the regression test? If so, this change should not affect this PR. In case, could you guys give the final approve for this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pcarruscag

pcarruscag commented Feb 7, 2025

Copy link
Copy Markdown
Member

Everything we put in tutorials must have a regression test in tutorials.py, no test, no approval.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bigfooted bigfooted mentioned this pull request Oct 31, 2025
Missing Tutorial #70
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcarruscag pcarruscag pcarruscag left review comments
@joshkellyjak joshkellyjak joshkellyjak left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@alecappiello @pcarruscag @joshkellyjak
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.