GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Feature nemo tutorial by jtneedels · Pull Request #120 · su2code/su2code.github.io

Conversation

@jtneedels

@jtneedels jtneedels commented Jan 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adding NEMO tutorials, starting with inviscid wedge case. See addition of files to tutorial repo: su2code/Tutorials#37

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jtneedels added 2 commits January 5, 2023 13:22
@jtneedels
initial commit
09cda9b 
Signed-off-by: jtneedels <[email protected]>
@jtneedels
adding invwedge tutorial
c7d15f6 
Signed-off-by: jtneedels <[email protected]>
@pr-triage pr-triage Bot added the PR: draft label Jan 23, 2023
jtneedels added 2 commits January 23, 2023 11:47
@jtneedels
remove ds store
57e259a 
Signed-off-by: jtneedels <[email protected]>
@jtneedels
remove ds store
7d4fe4d 
Signed-off-by: jtneedels <[email protected]>
@jtneedels
jtneedels marked this pull request as ready for review January 23, 2023 19:49
@pr-triage pr-triage Bot added PR: unreviewed and removed PR: draft labels Jan 23, 2023
@jtneedels jtneedels mentioned this pull request Jan 23, 2023
Add nemo inviscid wedge tutorial su2code/Tutorials#37
Open
@jtneedels
jtneedels requested review from WallyMaier and pcarruscag January 23, 2023 19:50
@pcarruscag

pcarruscag commented Jan 23, 2023

Copy link
Copy Markdown
Member

You need to change the .yml files for the dropdown menus
https://github.com/su2code/su2code.github.io/pull/103/files
jtneedels reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jtneedels
adding change to yml
6231d15 
Signed-off-by: jtneedels <[email protected]>
@jtneedels

jtneedels commented Jan 23, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @pcarruscag , PLTA, I think I addressed your comment above. Any other changes needed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pcarruscag
pcarruscag approved these changes Jan 24, 2023
View reviewed changes

@pcarruscag pcarruscag left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if the links point to new files you may want to merge the other PRs first

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pr-triage pr-triage Bot added PR: partially-approved and removed PR: unreviewed labels Jan 24, 2023
@pcarruscag

pcarruscag commented Jan 24, 2023

Copy link
Copy Markdown
Member

It the files are all in master, then merge this to master instead, and you can directly check if everything is ok
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jtneedels

jtneedels commented Jan 26, 2023

Copy link
Copy Markdown
Contributor Author

Thanks Pedro, yeah links point to files that are being uploaded in a separate PR - I'll make sure that PR gets merged first then merge to master here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
WallyMaier
WallyMaier reviewed Feb 9, 2023
View reviewed changes
Comment thread _tutorials/nemo/Inviscid_Hypersonic_Wedge/Inviscid_Hypersonic_Wedge.md
## Goals

Upon completion of this tutorial, the user will be familar with performing a simulation of external, inviscid flow over a 2D geometry using the NEMO Euler solver. The specific geometry chosen for the tutorial is a 10 degree wedge. Consequently, the following capabilities of SU2 will be showcased in the tutorial:
- Steady, 2D thermochenical nonequilibrium Euler equations

@WallyMaier WallyMaier Feb 9, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a bullet mentioning using the native/mpp library here

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pr-triage pr-triage Bot added PR: reviewed-approved and removed PR: partially-approved labels Feb 9, 2023
WallyMaier
WallyMaier reviewed Feb 9, 2023
View reviewed changes
Comment thread _tutorials/nemo/Inviscid_Hypersonic_Wedge/Inviscid_Hypersonic_Wedge.md
TIME_DISCRE_FLOW= EULER_IMPLICIT
```

In general, users can choose from explicit or implicit time integration schemes.

@WallyMaier WallyMaier Feb 9, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In general, users can choose from explicit or implicit time integration schemes.
In general, users can choose from any explicit or implicit time integration schemes in SU2.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bigfooted

bigfooted commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

@jtneedels, are there still things to be done for this tutorial?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jtneedels

jtneedels commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

@bigfooted Yeah, I think we actually want to switch to another test case for the tutorial - this case doesn't have great convergence.
bigfooted reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Base automatically changed from develop to master August 30, 2025 16:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WallyMaier WallyMaier WallyMaier left review comments
@pcarruscag pcarruscag pcarruscag approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

PR: reviewed-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jtneedels @pcarruscag @bigfooted @WallyMaier
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.