GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bump to v0.11.0, update `CHANGELOG.md` & `Example` by MaxDesiatov · Pull Request #143 · swiftwasm/JavaScriptKit

Conversation

@MaxDesiatov

@MaxDesiatov MaxDesiatov commented Nov 21, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I had to remove SwiftWasm 5.3 and 5.4 from CI because OpenCombine/OpenCombine#225 is reproducible with all code, not just OpenCombine, with old toolchains when Xcode 13.1 is installed.

I've also updated Example code to try using fetch with async/await and a section with a simple guide for this to README.md

Node.js and npm dependencies together with webpack.js config in Example directory were also updated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
MaxDesiatov added 2 commits November 21, 2021 23:53
@MaxDesiatov
Bump to v0.11.0, update CHANGELOG.md & Example
51d0cf4
@MaxDesiatov
Add simple async/await guide to README.md
26d0d9e
@MaxDesiatov
MaxDesiatov requested a review from a team November 21, 2021 23:06
@github-actions

github-actions Bot commented Nov 21, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Time Change: -680.25ms (6%) ✅

Total Time: 9,937ms

Test name Duration Change
Serialization/Write JavaScript number directly 199.75ms -65.5ms (32%) 🎉
Serialization/Write JavaScript string directly 214ms -24.5ms (11%) 👏
Serialization/Swift Int to JavaScript 2,979.25ms -395ms (13%) 👏
Serialization/Swift String to JavaScript 3,061.25ms -417.25ms (13%) 👏
Object heap/Increment and decrement RC 3,482.75ms +222ms (6%) 🔍

performance-action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MaxDesiatov
Use wasm-5.5-SNAPSHOT-2021-11-20-a
124f712
@MaxDesiatov

MaxDesiatov commented Nov 21, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I think it's a bit of a pain to test Tokamak with this new JSKit version without releasing everything in a slightly weird order. I think I'm going to do it like this (and this is roughly how I've previously done it):

  1. Release JSKit 0.11.0.
  2. Try carton from the latest main commit with new JSKit runtime, running tests on Tokamak's main branch.
  3. Release SwiftWasm 5.5 if all of the above seems to work fine.
  4. Release carton 0.12.0 with new JSKit runtime, default to newly released SwiftWasm 5.5 toolchain
  5. Release new Tokamak 0.9.0 with basic async/await support and other new features if all works fine.
  6. Submit a PR here on JSKit to use SwiftWasm 5.5.0 on CI.

WDYT?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MaxDesiatov added 2 commits November 22, 2021 00:16
@MaxDesiatov
Update CHANGELOG.md
1f31264
@MaxDesiatov
Update .swift-version
2002fb8
j-f1
j-f1 approved these changes Nov 22, 2021
View reviewed changes
@MaxDesiatov
Add acknowledgements to CHANGELOG.md
d09198d
@MaxDesiatov
MaxDesiatov merged commit 40b1614 into main Nov 22, 2021
@MaxDesiatov
MaxDesiatov deleted the bump-v0.11.0 branch November 22, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-f1 j-f1 j-f1 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@MaxDesiatov @j-f1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.