GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — BridgeJS: Include namespace prefix in ABI names for namespace-nested classes and structs by krodak · Pull Request #683 · swiftwasm/JavaScriptKit Conversation
Member
OverviewABI names for namespace-nested classes omit the namespace, causing symbol collisions when two namespace enums contain a class with the same bare name. For example, This PR adds an 1. Skeleton model - Added 2. SwiftToSkeleton - Constructor, method, static method, and static property ABI names now use 3. ExportSwift - Deinit, wrap, and 4. BridgeJSLink - Deinit, wrap, property className, and struct helper Wasm intrinsic names ( Before: After: 5. Collision test - Added Top-level (non-namespaced) classes and structs are unaffected -
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
krodak
force-pushed
the
kr/namespace-abi-names
branch
from
085ad29 to
c03f108
Compare
…classes and structs
krodak
force-pushed
the
kr/namespace-abi-names
branch
from
c03f108 to
494ed16
Compare
kateinoigakukun
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |