GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — BridgeJS: support imports of JS `Promise` as `async` Swift by MaxDesiatov · Pull Request #707 · swiftwasm/JavaScriptKit Conversation
|
| import Testing | ||
| import JavaScriptKit | ||
|
|
||
| @Suite struct AsyncImportTests { |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Can you follow the pattern we have in recent other suites like https://github.com/swiftwasm/JavaScriptKit/blob/main/Tests/BridgeJSRuntimeTests/ArraySupportTests.swift ?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate? Which specific pattern are you referring to? I suppose that's not the use of XCTest?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I mean, I'd like to avoid adding more and more imports in prelude.mjs and want to split into separate file like this: https://github.com/swiftwasm/JavaScriptKit/blob/main/Tests/BridgeJSRuntimeTests/JavaScript/ArraySupportTests.mjs
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks, also addressed
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
c8de4e0 to
14561d4
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.