GeezerVison is showing github.com — BridgeJS: Unify @JS struct parameter lowering onto the stack ABI by kateinoigakukun · Pull Request #798 · swiftwasm/JavaScriptKit
Conversation
Summary
@JS struct bridgeJSLowerParameter() used toJSObject() (object-id ABI). Swift→JS callbacks and the rest of the stack ABI expect a stack push + JS structHelpers.*.lift(). The object-id path pushed then lifted into a JS object, discarded the id, and left the stacks empty for the callback glue — so JS read garbage.
This matches arrays/dictionaries: lower = stack push. ImportTS non-optional structs use the same stack ABI (optional structs already did).
Problematic case
@JS struct Vector2D {
var dx: Double
var dy: Double
}
@JS class TextProcessor {
@JS func observeVector(_ callback: (Vector2D) -> Void) {
callback(Vector2D(dx: 1.5, dy: 2.5))
}
}
processor.observeVector((vector) => {
// Before: { dx: undefined, dy: undefined, ... }
// After: { dx: 1.5, dy: 2.5, ... }
});
Same failure mode for any Swift→JS typed closure that takes a non-optional @JS struct (e.g. observation payloads). Bool fields were especially misleading: empty-stack i32 pops yielded undefined, and undefined !== 0 became true.
Fix
_BridgedSwiftStruct.bridgeJSLowerParameter() → bridgeJSStackPush()
- ImportTS non-optional struct param/return ABI → stack (same as ExportSwift / optionals)
- Runtime regression:
observeVector / mapVector in ClosureSupportTests
Test plan
- BridgeJS plugin tests / snapshots
-
ClosureSupportTests.testRunJsClosureSupportTests (struct callback params)
-
SwiftStructTests.testSwiftStructInImportedSignature (ImportTS stack unify)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bridgeJSLowerParameter for structs used toJSObject(), so Swift→JS
callbacks discarded the stack and JS lift() read garbage. Match arrays:
stack-push on lower, and use the same ABI for ImportTS non-optional structs.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
krodak
krodak approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.