GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Automatically publish to npm by j-f1 · Pull Request #84 · swiftwasm/JavaScriptKit

Conversation

@j-f1

@j-f1 j-f1 commented Sep 26, 2020

Copy link
Copy Markdown
Member

I copied the code from GitHub’s example.

This should activate whenever a new release is tagged.

@kateinoigakukun needs to upload an npm token to the secrets section of the repo for this to work.

Let’s give this a try for v0.7.1.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@j-f1
Automatically publish to npm
f635527 
This should activate whenever a new release is tagged.
@github-actions

github-actions Bot commented Sep 26, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Time Change: +532.75ms (3%)

Total Time: 15,681.25ms

Test name Duration Change
Serialization/Swift Int to JavaScript 5,872ms +346.5ms (5%) 🔍
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 184ms 0ms
Serialization/Write JavaScript string directly 189.25ms +0.25ms
Serialization/Swift String to JavaScript 5,939.5ms +224.25ms (3%)
Object heap/Increment and decrement RC 3,496.5ms -38.25ms (1%)

performance-action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MaxDesiatov
MaxDesiatov reviewed Sep 26, 2020
View reviewed changes
Comment thread .github/workflows/npm-publish.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/npm-publish.yml
with:
node-version: 12
registry-url: https://registry.npmjs.org/
- run: npm ci

@MaxDesiatov MaxDesiatov Sep 26, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, wouldn't it require a ci script to be defined?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@j-f1 j-f1 Sep 27, 2020

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm ci is like npm install but it never modifies package.json.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MaxDesiatov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@kateinoigakukun

kateinoigakukun commented Sep 27, 2020

Copy link
Copy Markdown
Member

Could you test this script on another test repo?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@j-f1
Remove test script
10a5998
@MaxDesiatov

MaxDesiatov commented Sep 27, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've verified it works in my gatsby-remark-codemirror package. Good to go, you just need to add the npm_token secret, and make sure your npm OTP is authorization-only if you have it enabled.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kateinoigakukun

kateinoigakukun commented Sep 27, 2020

Copy link
Copy Markdown
Member

@MaxDesiatov @j-f1 Could you tell me your npm account name? I'll invite you as owner.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MaxDesiatov

MaxDesiatov commented Sep 27, 2020

Copy link
Copy Markdown
Member

I'm maxd on npm 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MaxDesiatov
MaxDesiatov requested a review from kateinoigakukun September 27, 2020 12:06
MaxDesiatov
MaxDesiatov approved these changes Sep 27, 2020
View reviewed changes

@MaxDesiatov MaxDesiatov left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kateinoigakukun
kateinoigakukun approved these changes Sep 27, 2020
View reviewed changes
@kateinoigakukun
kateinoigakukun merged commit 29fb15f into main Sep 27, 2020
@kateinoigakukun
kateinoigakukun deleted the npm-publish branch September 27, 2020 14:52
@j-f1

j-f1 commented Sep 27, 2020

Copy link
Copy Markdown
Member Author

I’m j-f on npm.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@j-f1 j-f1 mentioned this pull request Sep 27, 2020
Get automatic publishing set up for npm #83
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes
@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@j-f1 @kateinoigakukun @MaxDesiatov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.