GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add missing .npmignore, bump version to 0.7.2 by MaxDesiatov · Pull Request #85 · swiftwasm/JavaScriptKit

Conversation

@MaxDesiatov

@MaxDesiatov MaxDesiatov commented Sep 28, 2020

Copy link
Copy Markdown
Member

In 0.7.1 the runtime files are still not available through npm. The reason was this:

If there is a .gitignore file, and .npmignore is missing, .gitignore’s contents will be used instead.

The Runtime directory had .gitignore that mentioned the lib subdirectory with transpiled files. This made sense, but absence of .npmignore excluded these files from uploading.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MaxDesiatov
Add missing .npmignore, bump version to 0.7.2
a1634db
@MaxDesiatov MaxDesiatov added the bug Something isn't working label Sep 28, 2020
@MaxDesiatov
MaxDesiatov requested review from a team, j-f1 and kateinoigakukun and removed request for a team September 28, 2020 09:32
@github-actions

github-actions Bot commented Sep 28, 2020

Copy link
Copy Markdown

Time Change: +238ms (1%)

Total Time: 13,734.25ms

ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 174.75ms +4.25ms (2%)
Serialization/Write JavaScript string directly 176.75ms +1.25ms (0%)
Serialization/Swift Int to JavaScript 5,026ms +150ms (2%)
Serialization/Swift String to JavaScript 5,260.75ms +234ms (4%)
Object heap/Increment and decrement RC 3,096ms -151.5ms (4%)

performance-action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
j-f1
j-f1 approved these changes Sep 28, 2020
View reviewed changes
@j-f1
j-f1 merged commit 6e84a70 into main Sep 28, 2020
@j-f1
j-f1 deleted the missing-npmignore branch September 28, 2020 15:02
@j-f1

j-f1 commented Sep 28, 2020

Copy link
Copy Markdown
Member

The files are now present! https://unpkg.com/browse/[email protected]/Runtime/lib/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MaxDesiatov

MaxDesiatov commented Sep 28, 2020

Copy link
Copy Markdown
Member Author

Awesome, thanks for tagging the release!
j-f1 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-f1 j-f1 j-f1 approved these changes
@kateinoigakukun kateinoigakukun Awaiting requested review from kateinoigakukun

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@MaxDesiatov @j-f1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.