GeezerVison

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 8.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Thank you for the fix, and welcome. I retargeted the PR to 8.1, where the deprecation and the docblock were introduced, and pushed the merge-ready version to your branch:

• the @param lines keep the API types (ExposeSecurityLevel, string[]): the union types belong to the BC layer, not to the documented signature. The note now says which argument the bool is: Passing the removed "bool $eraseCredentials" as 6th argument (pre-8.1 signature) is deprecated since Symfony 8.1;
• the description is rewritten: the argument was still present in 7.4 and deprecated in 8.1 (it was the eraseCredentials() method that 8.0 removed), and the header table now has the License row that the checks look for.

Thank you @webdevsamran.