GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — New approach for checking we are loading the right file by t8y8 · Pull Request #62 · tableau/document-api-python

Conversation

@t8y8

@t8y8 t8y8 commented Jul 26, 2016

Copy link
Copy Markdown
Contributor

This subsumes #60.

Here's an approach for feedback, I pulled the logic up into the xml_open class because otherwise I'd need to pass the root tag all the way down through the helper functions and it made the try-with-if-raise nesting complex in find_file_in_zip.

I want to clean up a bit more of that logic, but this is a good start for feedback

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@t8y8
Proper validation that Workbooks load 'twb(x)' and Datasources load '…
66a1321 
…tds(x)' files only
@t8y8 t8y8 mentioned this pull request Jul 26, 2016
Small bugfix in xfile opening #60
Closed
@t8y8
Small cleanup, move the try inside the with
68e602a
@t8y8 t8y8 mentioned this pull request Jul 26, 2016
Coverage Report #63
Closed
@t8y8
Add some tests to make sure I don't break anything and cleanup a few …
5ef0fa0 
…small bits
@graysonarts

graysonarts commented Jul 26, 2016

Copy link
Copy Markdown
Contributor

🚀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@t8y8
t8y8 merged commit 4d6ff51 into tableau:development Jul 27, 2016
@t8y8
t8y8 deleted the bugfix-60-xml-open branch July 27, 2016 10:57
@graysonarts graysonarts modified the milestone: 2016.08 release Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2016.08 release (v0.3)

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@t8y8 @graysonarts
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.