GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||
GeezerVison is showing github.com — Create New Connections per #68 by t8y8 · Pull Request #69 · tableau/document-api-python Conversation
Contributor
This is all that we'd need for creating connections from scratch. Authentication isn't validated right now so it's not very safe, it defaults to '' because I need to research more how this attribute works Feedback:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Totally a bug in my dbclass code.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Alright, I've totally got a prototype working for creating datasources (V10) as well. It's ugly but wanted to get it out for discussion. I don't actually know the rules for what makes a good 'name' -- it appears to be dbclass + a 28 character random string ('postgres.1of3kl00aoax5d1a1ejma1397430'), it's definitely not a UUID though |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Alright, pushed my attempt. @RussTheAerialist I'm not sure if it's overcomplicating things or not, but it feels like this logic could live in an, bleck, DatasourceBuilder, or something like that. It could take in a version parameter and know how to build 9.X vs 10.X as well. Of course, none of that addresses the problem that these are 'bare' datasources without relations, metadata-records, or fields. Thoughts? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
|
|
||
| def make_unique_name(dbclass): | ||
| rand_part = ''.join(random.choice( |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Our unique names are a hash based on the current time, so we should probably do that rather than random data. I can find the relevant code if you need it.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Please!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🚀 this will need to be changed once I get all of the editor+physical+logical splitting done but for now, yay! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Awesome! At least it'll let us play with some examples, and the tests will stay valid. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.