GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve test coverage by graysonarts · Pull Request #70 · tableau/document-api-python

Conversation

@graysonarts

@graysonarts graysonarts commented Aug 9, 2016

Copy link
Copy Markdown
Contributor

Address some additional testing for #63

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Russell Hay added 4 commits August 9, 2016 13:20
Russell Hay
Removing code that should have been removed in a previous checkin
f005d53
Russell Hay
another small improvement
894bc9d
Russell Hay
Adding coverage for one of the xfile edge cases
5fb80bf
Russell Hay
Adding a few additional tests
3807c33
t8y8
t8y8 reviewed Aug 9, 2016
View reviewed changes
Comment thread test/test_field.py Outdated

class FieldsUnitTest(unittest.TestCase):
def test_field_throws_if_no_data_passed_in(self):
try:

@t8y8 t8y8 Aug 9, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style preference nit, I like context mangers for the exception tests because self.fail somehow looks ugly to me.

with self.assertRasises(AttributeError, "Field should have thrown"):
    Field()

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@t8y8

t8y8 commented Aug 9, 2016

Copy link
Copy Markdown
Contributor

🚀

Really minor comments.

Can you post the coverage update %'s? Curious!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graysonarts

graysonarts commented Aug 9, 2016

Copy link
Copy Markdown
Contributor Author

Okay, I'll make those changes and send another update

Name                                     Stmts   Miss Branch BrPart  Cover
--------------------------------------------------------------------------
tableaudocumentapi/__init__.py               6      0      0      0   100%
tableaudocumentapi/connection.py            35      1      2      0    97%
tableaudocumentapi/datasource.py            83      0     18      0   100%
tableaudocumentapi/dbclass.py                3      0      0      0   100%
tableaudocumentapi/field.py                 81      2     30      2    96%
tableaudocumentapi/multilookup_dict.py      43      2     14      0    96%
tableaudocumentapi/workbook.py              55      0     16      0   100%
tableaudocumentapi/xfile.py                 65      0     16      0   100%
--------------------------------------------------------------------------
TOTAL                                      371      5     96      2    99%
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Russell Hay
Updating based on code review feedback.
2b19a9d 
Note: assertRaises does not take a message
@t8y8

t8y8 commented Aug 9, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

🐓 🚀 🌕

Edit: Yeah, the msg argument is 3.3+, sorry :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graysonarts
graysonarts merged commit 90d6a28 into tableau:development Aug 9, 2016
@graysonarts
graysonarts deleted the improve-coverage branch August 9, 2016 22:38
@graysonarts graysonarts modified the milestone: 2016.08 release Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2016.08 release (v0.3)

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@graysonarts @t8y8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.