GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — #72 Add description to the field object by graysonarts · Pull Request #73 · tableau/document-api-python

Conversation

@graysonarts

@graysonarts graysonarts commented Aug 22, 2016

Copy link
Copy Markdown
Contributor

Partial implementation of #72 (only implements reading)
Pull in the description if it exists on a <column> tag.
This change returns the entire <desc> tag including all subtags.
e.g.:

<desc>
  <formatted-text>
    <run>Total number of people in a country</run>
  </formatted-text>
</desc>

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Russell Hay
Add description to the field object
bb67bdc 
Pull in the description if it exists on a `<column>` tag.
This change returns the entire `<desc>` tag including all subtags.
e.g.:

```
<desc>
  <formatted-text>
    <run>Total number of people in a country</run>
  </formatted-text>
</desc>
```
@graysonarts graysonarts added the enhancement label Aug 22, 2016
t8y8
t8y8 reviewed Aug 22, 2016
View reviewed changes
Comment thread test/test_datasource.py Outdated
def test_datasource_field_description(self):
actual = self.ds.fields['[a]'].description
self.assertIsNotNone(actual)
contains_string = actual.index(u'muted gray')

@t8y8 t8y8 Aug 22, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

contains_string = u'muted gray' in actual
self.assertTrue(contains_string)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@t8y8

t8y8 commented Aug 22, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

🚀 just a minor nit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Russell Hay
improving the test code to use 'in'
7198756
@graysonarts
graysonarts merged commit 202acea into tableau:development Aug 23, 2016
@graysonarts
graysonarts deleted the 72-add-desc-to-field-reading branch August 23, 2016 16:20
@graysonarts graysonarts modified the milestone: 2016.08 release Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

2016.08 release (v0.3)

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@graysonarts @t8y8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.