GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add caption support for datasources by graysonarts · Pull Request #99 · tableau/document-api-python

Conversation

@graysonarts

@graysonarts graysonarts commented Oct 18, 2016

Copy link
Copy Markdown
Contributor

Addresses #98

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Russell Hay added 2 commits October 18, 2016 08:57
Russell Hay
Add caption support for datasources
c0f201c
Russell Hay
fix a pep8 issue E303
c039ae7
t8y8
t8y8 approved these changes Oct 18, 2016
View reviewed changes

@t8y8 t8y8 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, I think the test cleanup can definitely wait until a new PR. Do consider the 'removing caption' case though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tableaudocumentapi/datasource.py Outdated

@caption.setter
def caption(self, value):
self._datasourceXML.attrib['caption'] = value

@t8y8 t8y8 Oct 18, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We do .set everywhere else (or everywhere in connections)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/test_datasource.py
elif os.path.isfile(path):
os.unlink(path)

def get_temp_file(self, filename):

@t8y8 t8y8 Oct 18, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 3 ways of doing temp file management now.

xfile.temporary_directory has a context manager that creates and deletes a temp dir
bvt.py does a less advanced version of your cleanup methods here
Then these cleanup methods here.

This can be another PR, maybe we want to unify them, at least across the tests?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@graysonarts graysonarts Oct 18, 2016

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I'll do a pass to create a "temp file wrapper that both library code and tests can use" along with the auto clean up base test class.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tableaudocumentapi/datasource.py
def caption(self):
return self._caption

@caption.setter

@t8y8 t8y8 Oct 18, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all datasources guaranteed to have a caption or would you ever want to remove it?

We could apply the None strategy like we do for port

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@graysonarts graysonarts Oct 18, 2016

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more idiomatic to do del ds.caption

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Russell Hay
Add ability to remove the caption using del
3315788
@t8y8

t8y8 commented Oct 18, 2016

Copy link
Copy Markdown
Contributor

🚀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graysonarts
graysonarts merged commit 9e1d875 into tableau:development Oct 18, 2016
@graysonarts
graysonarts deleted the 98-add-caption-support branch October 18, 2016 21:24
@graysonarts graysonarts mentioned this pull request Oct 18, 2016
Datasource needs to support changing the caption which is not currently supported. #98
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@t8y8 t8y8 t8y8 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@graysonarts @t8y8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.