GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — Add worker resource and queue metrics to OTel instrumentation by Mohammed0tarek · Pull Request #613 · taskiq-python/taskiq Conversation
Contributor
What this addsThis extends the existing Worker resource utilization (observable gauges, worker process only):
Both gauges are gaurded by Worker queue depth (UpDownCounters):
Why UpDownCounter for the queue metricsI didn't want to mess with the queue definition (they are local variables) so gauges where not the right thing TestsAdded tests for all four metrics to
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
s3rius
approved these changes
Add counters and histograms to OpenTelemetryMiddleware: - tasks_sent: producer-side counter per task name - task_success / task_errors: consumer-side counters with retry_error attribute - task_execution_time: histogram using result.execution_time - task_wait_time: histogram measuring queue time from send to receive via UTC timestamps in labels Add tests covering all instruments, retry_error attribute paths, and queue time correctness. - Add worker_active_tasks UpDownCounter driven by pre/post_execute hooks - Add worker_prefetched_tasks UpDownCounter via on_prefetch_queue_add/remove hooks in receiver - Add worker_cpu_utilization and worker_memory_utilization observable gauges (worker process only) - Add tests for all new metrics
s3rius
force-pushed
the
observability/extra_open_telemetry_metrics
branch
from
8bf420d to
4188421
Compare
|
There was an error while loading. Please reload this page.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #613 +/- ## ========================================== + Coverage 79.37% 79.76% +0.38% ========================================== Files 69 69 Lines 2473 2525 +52 ========================================== + Hits 1963 2014 +51 - Misses 510 511 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.