GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed code block multiline encoding on quotes/span by Igoranze · Pull Request #61 · textile/python-textile

Conversation

@Igoranze

@Igoranze Igoranze commented Apr 10, 2018

Copy link
Copy Markdown

Hi,
There was an error on the python-textile module which was rendering codeblocks multiline as follows:

bc.. This is some TEXT inside a "Code BLOCK"

{
  if (JSON) {

    return {"JSON":"value"}
  }
}

Back to 10-4 CAPS 

p.. Some multiline Paragragh

Here is some output!!! "Some" CAPS

Became:

<pre><code>This is some TEXT inside a &quot;Code BLOCK&quot;

{
  if (&lt;span class=&quot;caps&quot;&gt;JSON&lt;/span&gt;) {

    return {<a href=""><span class="caps">JSON</span></a>&amp;#8220;value&amp;#8221;}
  }
}


Back to 10-4 &lt;span class=&quot;caps&quot;&gt;CAPS&lt;/span&gt; </code></pre>

<p>Some multiline Paragragh

Here is some output!!! &#8220;Some&#8221; <span class="caps">CAPS</span></p>

There are a multiple things wrong here.

<span class='caps'>...</span> (Inside codeblock)
<a href>...</a> (On a word that is not a link)
&amp;#8220; (Double escaping of quotes)

Fixed it by checking the inner_tag of block. If that is equal to 'code' do the same rendering as on the 'pre' tag.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ikirudennis and others added 8 commits June 3, 2017 17:21
@ikirudennis
Merge branch 'release/2.3.12'
d7f5a75
@ikirudennis
Merge branch 'release/2.3.13'
ae3504f
@ikirudennis
Merge branch 'release/2.3.14'
c31d41e
@ikirudennis
Merge branch 'release/2.3.15'
059e5e9
@ikirudennis
Merge branch 'master' of github.com:textile/python-textile
bf40e2d
@ikirudennis
Merge branch 'release/2.3.16'
713b83a
@ikirudennis
Merge branch 'release/3.0.0'
8b8d973
@ivanspengen-ct
Fixed code block multiline encoding on quotes/span
3188b0b
@codecov-io

codecov-io commented Apr 10, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #61 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #61   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           12     12           
  Lines         1195   1195           
  Branches       219    219           
======================================
  Hits          1195   1195
Impacted Files Coverage Δ
textile/core.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f44b48...3188b0b. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@coveralls

coveralls commented Apr 10, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 3188b0b on Igoranze:master into 8b8d973 on textile:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Igoranze
Igoranze changed the base branch from master to develop April 10, 2018 08:45
@ikirudennis
ikirudennis merged commit 584006d into textile:develop Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Igoranze @codecov-io @coveralls @ikirudennis @ivanspengen-ct
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.