Description

phiw13

opened on Feb 2, 2024

Issue body actions

1/ some fields are missing their <label for=> tags: “name”, “existing file”, ”download count”

2/ the “missing” file panel, incorrect layout for the “Existing file” field, the surrounding <div>s are missing

Expected:

<div class="txp-form-field exist-file-name"> 
  <div class="txp-form-field-label"><label for="file-existing">Existing file</label></div>
  <div class="txp-form-field-value">
    <select name="filename" id="file-existing">
      <option value="" selected="selected">&nbsp;</option>
      <option value="darkness_v2.pdf" dir="auto">darkness_v2.pdf</option>
    </select>
  </div>
</div>

Or does this widget need its own form (as was the case with TXP 4.8.8) ? Then it might be better placed next/after the Upload/assign file form at the top?

Activity

1. petecooper

   added

   admin-side

   accessibility / a11y

   on Feb 12, 2024
2. phiw13 commented on Feb 16, 2024

   

   phiw13

   on Feb 16, 2024

   Author

   More actions

   The second issue is mostly fixed now (I think by this), although there could eventually be room for improvement.

   (some todo for this: #1903)
3. philwareham

   added this to the v5.0 milestone on Mar 1, 2024
4. petecooper commented on Feb 8, 2026

   

   petecooper

   on Feb 8, 2026

   Member

   More actions

   @phiw13 At the current time, are there any easy wins we can achieve from your perspective to improve or resolve this for v4.9.1?
5. phiw13 commented on Feb 11, 2026

   

   phiw13

   on Feb 11, 2026

   Author

   More actions

   At the current time, are there any easy wins we can achieve from your perspective to improve or resolve this for v4.9.1?

   Dunno… That “Replace file” part is still the same problematic organisation/display.
   The suggestion I made for a possible alternative is still up for now: https://dev.l-c-n.com/txp-4.9/secondary/content-file_edit-idea.html

Issue actions