GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — BaseTools: Add VS2022 support. by apop5 · Pull Request #5799 · tianocore/edk2

Conversation

@apop5

@apop5 apop5 commented Jun 20, 2024

Copy link
Copy Markdown
Contributor

Description

Adding support for VS2022 build tools.

Adding tools_def for VS2022.
Update WindowsVsToolChain to support VS2022.
Update set_vsPrefix_envs and toolsetup and edksetup to support VS2022.

  • Breaking change?
    • Breaking change - Will this cause a break in build or boot behavior?
    • Examples: Add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does the change have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Ran build on local system (tool_chain_target=vs2022)
Ran CI on local system (tool_chain_target=vs2022).
Both tests found vs2022.

Integration Instructions

N/A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@apop5
apop5 marked this pull request as ready for review June 20, 2024 01:16
@apop5

apop5 commented Jun 20, 2024

Copy link
Copy Markdown
Contributor Author

@BCRAN

can you please take a look at this when you get a chance?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost
ghost self-requested a review June 20, 2024 01:44
@ghost ghost changed the title BuildTools: Add VS2022 support. BaseTools: Add VS2022 support. Jun 20, 2024
ghost
ghost reviewed Jun 20, 2024
View reviewed changes
Comment thread BaseTools/Conf/tools_def.template Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread BaseTools/Conf/tools_def.template Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread BaseTools/Conf/tools_def.template Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread BaseTools/Plugin/WindowsVsToolChain/WindowsVsToolChain.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread BaseTools/Plugin/WindowsVsToolChain/WindowsVsToolChain.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread BaseTools/set_vsprefix_envs.bat Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ghost
ghost requested a review from lgao4 June 20, 2024 02:01
@apop5
apop5 force-pushed the personal/apop5/vs2022 branch from f32fbeb to 268430c Compare June 20, 2024 04:38
lgao4
lgao4 reviewed Jun 24, 2024
View reviewed changes
Comment thread BaseTools/Conf/tools_def.template Resolved

Uh oh!

There was an error while loading. Please reload this page.
@apop5
apop5 force-pushed the personal/apop5/vs2022 branch from 268430c to 7e8e63b Compare June 24, 2024 15:28
@matthewfcarlson @apop5
BaseTools: Add VS2022 support.
36c019a 
Adding tools_def for VS2022.
Update WindowsVsToolChain to support VS2022.
Update set_vsPrefix_envs and toolsetup and edksetup to support VS2022.

Signed-off-by: Aaron Pop <[email protected]>
@apop5
apop5 force-pushed the personal/apop5/vs2022 branch from 7e8e63b to 36c019a Compare June 26, 2024 02:16
@apop5

apop5 commented Jul 3, 2024

Copy link
Copy Markdown
Contributor Author

@BCRAN @lgao4

Do you have any other concerns?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@os-d os-d mentioned this pull request Jul 5, 2024
fix 4774 #5876
Closed
3 tasks
ghost
ghost approved these changes Jul 8, 2024
View reviewed changes
@ghost ghost added the push Auto push patch series in PR if all checks pass label Jul 8, 2024
@mergify
Merge branch 'master' into personal/apop5/vs2022
228af80
@mergify
mergify Bot merged commit 95a6892 into tianocore:master Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgao4 lgao4 lgao4 left review comments
+2 more reviewers
@os-d os-d os-d left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

push Auto push patch series in PR if all checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@apop5 @lgao4 @os-d @matthewfcarlson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.