GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Openssl 3.0.15 by liyi77 · Pull Request #6160 · tianocore/edk2

Conversation

@liyi77

@liyi77 liyi77 commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

Description

https://bugzilla.tianocore.org/show_bug.cgi?id=4842

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • fix CVE-2024-6119: https://www.cve.org/CVERecord?id=CVE-2024-6119
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Unit test of CryptoPkg.

Integration Instructions

NA

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot added the impact:security This change has a direct security impact such as changing a crypto algorithm. label Sep 4, 2024
@tianocore-assign-reviewers
tianocore-assign-reviewers Bot requested a review from jyao1 September 4, 2024 05:06
@liyi77

liyi77 commented Sep 4, 2024

Copy link
Copy Markdown
Contributor Author

Size impact between 3.0.9~3.0.15(no compressed):
No increase in Pei driver [Only AES, SHA, SM3]
65KB increase in FullDxe driver [All]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AkechiShiro
AkechiShiro reviewed Sep 8, 2024
View reviewed changes
Comment thread CryptoPkg/Library/OpensslLib/OpensslGen/include/openssl/bio.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@liyi77
liyi77 force-pushed the openssl3.0.15 branch from 4bcd460 to 3aa4e5e Compare September 19, 2024 05:35
@liyi77 liyi77 closed this Sep 19, 2024
@liyi77 liyi77 reopened this Sep 19, 2024
liyi77 added 2 commits September 23, 2024 13:25
@liyi77
CryptoPkg: Update openssl submodule to 3.0.15
9ebcd3f 
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4842

CVE-2024-6119 affects TLS-client implementation of EDK2. Fix it by
updating to 3.0.15.

Signed-off-by: Li Yi <[email protected]>
@liyi77
CryptoPkg: Update generated files based on openssl 3.0.15
038cc9d 
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4842

Signed-off-by: Li Yi <[email protected]>
@liyi77
liyi77 force-pushed the openssl3.0.15 branch from 3aa4e5e to 038cc9d Compare September 23, 2024 05:25
@liyi77

liyi77 commented Sep 23, 2024

Copy link
Copy Markdown
Contributor Author

Hi @jyao1 , could you take a look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jyao1

jyao1 commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

@liyi77 , would you please provide the compressed size difference?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jyao1
jyao1 approved these changes Sep 27, 2024
View reviewed changes
@liyi77

liyi77 commented Sep 27, 2024

Copy link
Copy Markdown
Contributor Author

@liyi77 , would you please provide the compressed size difference?

there will be ~15KB increase after compressed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jyao1 jyao1 added the push Auto push patch series in PR if all checks pass label Sep 27, 2024
@mergify
Merge branch 'master' into openssl3.0.15
11df302
@mergify
mergify Bot merged commit 3ed4f43 into tianocore:master Sep 27, 2024
@DorLevi95 DorLevi95 mentioned this pull request Jan 6, 2025
Crypto migration to Openssl 3.0.15 microsoft/mu_crypto_release#99
Merged
1 of 5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@AkechiShiro AkechiShiro AkechiShiro left review comments
@jyao1 jyao1 jyao1 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

impact:security This change has a direct security impact such as changing a crypto algorithm. push Auto push patch series in PR if all checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@liyi77 @jyao1 @AkechiShiro
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.