GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — DynamicTablesPkg: Generates X64 MADT and CPU SSDT Topology Table by abdattar · Pull Request #6443 · tianocore/edk2

Conversation

@abdattar

@abdattar abdattar commented Nov 15, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Introduce support for generating ACPI CPU SSDT table for the X64 architecture.

Cc: Sami Mujawar [email protected]
Cc: Pierre Gondois [email protected]

Description

This PR contains two patches
Patch 1) Adds ACPI MADT generator library for X64 platform.
which handles various APIC structures within a system,
including Local APIC, IO APIC, Interrupt Source Override, and Local APIC NMI.
Patch 2) Implements the X64 support for existing ACPI CPU SSDT topology generator library.
Adds X64 related supporting functions.
Creates the ACPI cpu device object.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Tested on AMD platform.

Integration Instructions

N/A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@abdattar
abdattar force-pushed the CpuTopo branch 2 times, most recently from 60d29dc to 879eeaf Compare November 18, 2024 13:48
@mgamal

mgamal commented Nov 18, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Code looks pretty straightforward implementing building the local APIC data for x86_64 MADT tables. Looks pretty good to me.

@abdattar The only thing I'd suggest is adding a bit more explanatory message in the commit messages. For example to briefly explain what the PR and each commit does, just to provide some context to the reviewers.

@samimujawar @pierregondois any other thoughts?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@abdattar
abdattar force-pushed the CpuTopo branch from 879eeaf to 93f3739 Compare November 20, 2024 07:19
pierregondois
pierregondois suggested changes Nov 20, 2024
View reviewed changes
Comment thread DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLib/MadtGenerator.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLib/MadtGenerator.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLib/MadtGenerator.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLib/MadtGenerator.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLib/MadtGenerator.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread DynamicTablesPkg/Library/Acpi/Common/AcpiSsdtCpuTopologyLib/X64/X64SsdtCpuTopologyGenerator.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@abdattar
abdattar force-pushed the CpuTopo branch from 93f3739 to f3719d7 Compare November 21, 2024 06:09
@abdattar abdattar changed the title DynamicTablesPkg: Generate X64 CPU SSDT Topology DynamicTablesPkg: Generates X64 MADT and CPU SSDT Topology Table Nov 21, 2024
@abdattar
abdattar marked this pull request as ready for review November 21, 2024 06:14
@tianocore-assign-reviewers
tianocore-assign-reviewers Bot requested a review from samimujawar November 21, 2024 06:14
@abdattar
abdattar force-pushed the CpuTopo branch from f3719d7 to 60f4106 Compare November 21, 2024 06:25
pierregondois
pierregondois suggested changes Nov 21, 2024
View reviewed changes
Comment thread DynamicTablesPkg/Include/X64NameSpaceObjects.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLib/MadtGenerator.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLib/MadtGenerator.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLib/MadtGenerator.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@abdattar
abdattar force-pushed the CpuTopo branch from 60f4106 to 09ee341 Compare November 22, 2024 02:51
@abdattar

abdattar commented Nov 28, 2024

Copy link
Copy Markdown
Contributor Author

Hi @pierregondois and @samimujawar,
Could you please review the patch.
Thanks
AbduL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pierregondois
pierregondois reviewed Nov 28, 2024
View reviewed changes
Comment thread DynamicTablesPkg/Library/Acpi/X64/AcpiMadtLib/MadtGenerator.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pierregondois

pierregondois commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

Hi @pierregondois and @samimujawar, Could you please review the patch. Thanks AbduL

Sorry for the delay. I just have one minor comment. Otherwise LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@abdattar
abdattar force-pushed the CpuTopo branch 2 times, most recently from 8b858aa to bf418f5 Compare November 28, 2024 11:45
abdattar added 2 commits November 28, 2024 12:08
@abdattar
DynamicTablesPkg: Add X64 MADT table generator
c6213ea 
Updates X64 namespace object.
Updates the object parser.
Updates the Readme.

Cc: Sami Mujawar <[email protected]>
Cc: Pierre Gondois <[email protected]>
Signed-off-by: Abdul Lateef Attar <[email protected]>
@abdattar
DynamicTablesPkg: Adds X64 support for CPU SSDT generator
4f177c1 
Introduce support for generating ACPI CPU SSDT table
for the X64 architecture.

Creates processor objects based on configuration data.

Cc: Sami Mujawar <[email protected]>
Cc: Pierre Gondois <[email protected]>
Signed-off-by: Abdul Lateef Attar <[email protected]>
@abdattar
abdattar force-pushed the CpuTopo branch from bf418f5 to 4f177c1 Compare November 28, 2024 12:18
samimujawar
samimujawar approved these changes Nov 28, 2024
View reviewed changes

@samimujawar samimujawar left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this patch.
These changes look good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@samimujawar samimujawar added the push Auto push patch series in PR if all checks pass label Nov 28, 2024
@pierregondois
pierregondois self-requested a review November 28, 2024 15:45
pierregondois
pierregondois approved these changes Nov 28, 2024
View reviewed changes
@pierregondois
pierregondois merged commit 5158b59 into tianocore:master Nov 28, 2024
@lgao4 lgao4 added the type:feature-request A new feature proposal label Feb 21, 2025
@abdattar
abdattar deleted the CpuTopo branch August 14, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@samimujawar samimujawar samimujawar approved these changes
@pierregondois pierregondois pierregondois approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

push Auto push patch series in PR if all checks pass type:feature-request A new feature proposal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@abdattar @mgamal @pierregondois @samimujawar @lgao4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.