GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tests: expect avail_min to default to period_size by slyon · Pull Request #284 · tinyalsa/tinyalsa

Conversation

@slyon

@slyon slyon commented Oct 27, 2026

Copy link
Copy Markdown

Since commit 5a2ae9c ("pcm: fix for mmap usecase"), pcm_open() sets pcm->config.avail_min to the period size if the caller passed 0. The PcmOutTest fixture's kDefaultConfig still leaves avail_min at 0, so PcmOutTest.GetConfig, which memcmp()s the config returned by pcm_get_config() against kDefaultConfig, always fails. Set avail_min explicitly to the value pcm_open() would pick anyway, which doesn't change the behaviour of any other test using this fixture.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@slyon
tests: expect avail_min to default to period_size
f5ab893 
Since commit 5a2ae9c ("pcm: fix for mmap usecase"), pcm_open() sets
pcm->config.avail_min to the period size if the caller passed 0. The
PcmOutTest fixture's kDefaultConfig still leaves avail_min at 0, so
PcmOutTest.GetConfig, which memcmp()s the config returned by
pcm_get_config() against kDefaultConfig, always fails. Set avail_min
explicitly to the value pcm_open() would pick anyway, which doesn't change
the behaviour of any other test using this fixture.

Signed-off-by: Lukas Märdian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@slyon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.