GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Workspace(feat[importers]): Add tmuxinator and teamocil parity fallbacks by tony · Pull Request #1049 · tmux-python/tmuxp

Conversation

@tony

@tony tony commented Jun 6, 2026

Copy link
Copy Markdown
Member

Summary

Stacked on #1048 to keep importer parity separate from runtime and lifecycle primitives.

  • parse tmuxinator cli_args / tmux_options values for -f, -L, and -S
  • resolve imported workspace config fallback paths relative to the saved workspace file before creating Server
  • map tmuxinator lifecycle hooks, pre-window commands, startup focus, synchronize, and named panes to tmuxp keys
  • expand teamocil pane normalization plus focus/options passthrough and import docs

Verification

Ran before commit:

$ rm -rf docs/_build; uv run ruff check . --fix --show-fixes; uv run ruff format .; uv run mypy; uv run py.test --reruns 0 -vvv; just build-docs;

Result: ruff clean, format unchanged, mypy clean, pytest 877 passed, 2 skipped, docs built successfully with 71 existing warnings.

Stack: depends on #1047 and #1048.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@codecov

codecov Bot commented Jun 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.48101% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.06%. Comparing base (d06d999) to head (b180d59).

Files with missing lines Patch % Lines
src/tmuxp/workspace/importers.py 77.77% 17 Missing and 15 partials ⚠️
src/tmuxp/cli/load.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           parity-lifecycle-hooks    #1049      +/-   ##
==========================================================
- Coverage                   83.13%   83.06%   -0.07%     
==========================================================
  Files                          32       32              
  Lines                        2982     3106     +124     
  Branches                      574      612      +38     
==========================================================
+ Hits                         2479     2580     +101     
- Misses                        356      371      +15     
- Partials                      147      155       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tony
tony force-pushed the parity-lifecycle-hooks branch from b7442dc to 8047b2c Compare June 6, 2026 23:16
@tony
tony force-pushed the parity-importer-fallbacks branch from e4d17c3 to 7feb8b2 Compare June 6, 2026 23:16
@tony
tony force-pushed the parity-lifecycle-hooks branch from 8047b2c to eebcf20 Compare June 7, 2026 01:29
@tony
tony force-pushed the parity-importer-fallbacks branch from 7feb8b2 to 03106c4 Compare June 7, 2026 01:29
@tony
tony force-pushed the parity-lifecycle-hooks branch from eebcf20 to 575d74a Compare June 7, 2026 11:14
@tony
tony force-pushed the parity-importer-fallbacks branch 2 times, most recently from 3703f2a to 628c20f Compare June 7, 2026 11:46
@tony
tony force-pushed the parity-lifecycle-hooks branch from 575d74a to 250222d Compare June 7, 2026 11:46
@tony

tony commented Jun 7, 2026

Copy link
Copy Markdown
Member Author

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tony
tony force-pushed the parity-importer-fallbacks branch from 628c20f to 381e7a2 Compare June 7, 2026 13:36
@tony
tony force-pushed the parity-lifecycle-hooks branch from 250222d to d22d8e1 Compare June 7, 2026 13:36
@tony tony mentioned this pull request Jun 7, 2026
docs: Per-parameter configuration reference, generated from a config schema #1050
Open
@tony
tony force-pushed the parity-importer-fallbacks branch from 381e7a2 to 9f78aab Compare June 7, 2026 14:48
@tony
tony force-pushed the parity-lifecycle-hooks branch from d22d8e1 to e104ea3 Compare June 7, 2026 14:48
@tony
tony force-pushed the parity-importer-fallbacks branch from 9f78aab to b7026c8 Compare June 7, 2026 15:21
@tony
tony force-pushed the parity-lifecycle-hooks branch from e104ea3 to 3e55df9 Compare June 7, 2026 15:21
This was referenced Jun 27, 2026
Workspace builder roadmap: classic default, pluggable builders, readiness policy, and parallel loading #1058
Open
Docs: document custom workspace builders #1063
Closed
@tony
tony force-pushed the parity-lifecycle-hooks branch from 3e55df9 to 03f2ba7 Compare July 4, 2026 14:52
@tony
tony force-pushed the parity-importer-fallbacks branch from b7026c8 to a8750be Compare July 4, 2026 14:55
@tony
tony force-pushed the parity-lifecycle-hooks branch from 03f2ba7 to 9688667 Compare July 4, 2026 15:43
@tony
tony force-pushed the parity-importer-fallbacks branch from a8750be to 9ed5e5f Compare July 4, 2026 15:43
@tony
tony force-pushed the parity-lifecycle-hooks branch from 9688667 to ad9bcfc Compare July 4, 2026 16:54
@tony
tony force-pushed the parity-importer-fallbacks branch from 9ed5e5f to fda4e96 Compare July 4, 2026 16:54
tony added 4 commits October 24, 2026 04:47
@tony
Workspace(feat[importers]): Add tmuxinator and teamocil parity fallbacks
309a1d0
why: Preserve common tmuxinator and teamocil configuration semantics
after import without bundling unrelated CLI commands into the parity
split.
what:
- Parse tmuxinator tmux flags into workspace server fallbacks and
  resolve config paths from the workspace file
- Map tmuxinator hooks, pre-window commands, startup focus,
  synchronize, and named panes to tmuxp keys
- Expand teamocil pane normalization and focus/options passthrough
- Update existing import fixtures whose expected output encodes the
  new pre-to-on_project_start mapping
@tony
test(importers): Cover tmuxinator and teamocil parity fallbacks
05577fc
why: Pin flag parsing, hook and pane mapping, and teamocil v1.x
normalization behavior.
what:
- Importer tests for cli_args parsing, startup focus, synchronize,
  named panes, and teamocil focus/options passthrough
- New fixture workspaces for edge cases (numeric names, aliases,
  named panes, v1.x format)
- Load CLI tests for workspace server fallbacks
@tony
docs(cli[import]): Document tmuxinator and teamocil fallback mappings
4140436
why: Make the importer's key mappings discoverable for users
migrating configs.
what:
- Note the fallback conversions on the import page
@tony
Workspace(fix[importers]): Assert importer warnings on schema fields
b180d59
why: The socket-override warning carried no structured fields and the
import tests matched message substrings against the logging
standards; the override message also used present tense for an event.
what:
- Add tmux_session extra to the socket-override warning and change
  "overrides" to "overrode"
- Assert the override and dropped-pane-key warnings via record extras
  and args instead of message text
@tony
tony force-pushed the parity-lifecycle-hooks branch from ad9bcfc to d06d999 Compare October 24, 2026 10:01
@tony
tony force-pushed the parity-importer-fallbacks branch from fda4e96 to b180d59 Compare October 24, 2026 10:01

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@tony
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.