GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — Workspace(feat[importers]): Add tmuxinator and teamocil parity fallbacks by tony · Pull Request #1049 · tmux-python/tmuxp Conversation
Member
SummaryStacked on #1048 to keep importer parity separate from runtime and lifecycle primitives.
VerificationRan before commit: $ rm -rf docs/_build; uv run ruff check . --fix --show-fixes; uv run ruff format .; uv run mypy; uv run py.test --reruns 0 -vvv; just build-docs;Result: ruff clean, format unchanged, mypy clean, pytest
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## parity-lifecycle-hooks #1049 +/- ## ========================================================== - Coverage 83.13% 83.06% -0.07% ========================================================== Files 32 32 Lines 2982 3106 +124 Branches 574 612 +38 ========================================================== + Hits 2479 2580 +101 - Misses 356 371 +15 - Partials 147 155 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
b7442dc to
8047b2c
Compare
e4d17c3 to
7feb8b2
Compare
8047b2c to
eebcf20
Compare
7feb8b2 to
03106c4
Compare
eebcf20 to
575d74a
Compare
3703f2a to
628c20f
Compare
575d74a to
250222d
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
628c20f to
381e7a2
Compare
250222d to
d22d8e1
Compare
381e7a2 to
9f78aab
Compare
d22d8e1 to
e104ea3
Compare
9f78aab to
b7026c8
Compare
e104ea3 to
3e55df9
Compare
3e55df9 to
03f2ba7
Compare
b7026c8 to
a8750be
Compare
03f2ba7 to
9688667
Compare
a8750be to
9ed5e5f
Compare
9688667 to
ad9bcfc
Compare
9ed5e5f to
fda4e96
Compare
why: Preserve common tmuxinator and teamocil configuration semantics after import without bundling unrelated CLI commands into the parity split. what: - Parse tmuxinator tmux flags into workspace server fallbacks and resolve config paths from the workspace file - Map tmuxinator hooks, pre-window commands, startup focus, synchronize, and named panes to tmuxp keys - Expand teamocil pane normalization and focus/options passthrough - Update existing import fixtures whose expected output encodes the new pre-to-on_project_start mapping
why: Pin flag parsing, hook and pane mapping, and teamocil v1.x normalization behavior. what: - Importer tests for cli_args parsing, startup focus, synchronize, named panes, and teamocil focus/options passthrough - New fixture workspaces for edge cases (numeric names, aliases, named panes, v1.x format) - Load CLI tests for workspace server fallbacks
why: Make the importer's key mappings discoverable for users migrating configs. what: - Note the fallback conversions on the import page
why: The socket-override warning carried no structured fields and the import tests matched message substrings against the logging standards; the override message also used present tense for an event. what: - Add tmux_session extra to the socket-override warning and change "overrides" to "overrode" - Assert the override and dropped-pane-key warnings via record extras and args instead of message text
ad9bcfc to
d06d999
Compare
fda4e96 to
b180d59
Compare
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.