GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Workspace builder: bulk `set-option` helper + 10ms readiness polling by tony · Pull Request #1070 · tmux-python/tmuxp

Conversation

@tony

@tony tony commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Add ClassicWorkspaceBuilder._bulk_set_options, a batch-shaped helper routing the four set-option loops (session, global, per-window, options_after) through one entry point.
  • Tighten _wait_for_pane_ready polling interval 50ms → 10ms.

Note

The helper is forward-compat plumbing: today it is a plain loop producing identical tmux commands; the batch speedup lands once libtmux exposes a batch API. The polling tweak is the only current perf change.

Changes

  • workspace/builder/classic.py, tests, CHANGES.

Supersedes #1040, rebased onto the builder/classic.py package.

Test plan

  • full suite / mypy / ruff / build-docs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codecov

codecov Bot commented Jun 29, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.63%. Comparing base (98af6d1) to head (73c4adf).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1070      +/-   ##
==========================================
+ Coverage   82.55%   82.63%   +0.08%     
==========================================
  Files          31       31              
  Lines        2768     2781      +13     
  Branches      518      520       +2     
==========================================
+ Hits         2285     2298      +13     
  Misses        346      346              
  Partials      137      137

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tony tony changed the title Workspace builder: bulk set-option helper + 10ms readiness polling Workspace builder: bulk set-option helper + 10ms readiness polling Jun 29, 2026
@tony
tony force-pushed the builder-bulk-options branch from d736069 to 8b2e68b Compare July 4, 2026 14:05
@tony
tony force-pushed the master branch from 63172d2 to eeb6912 Compare July 25, 2026 17:00
@tony

tony commented Aug 22, 2026

Copy link
Copy Markdown
Member Author

Automated review finding. Recorded here so it is not lost. Nothing has been pushed to this branch and no fix is applied — this is a note, not a change request.

Session-scoped options: are applied with server scope

src/tmuxp/workspace/builder/classic.py passes -s when applying a workspace's session-level options:. In libtmux's OPTION_SCOPE_FLAG_MAP, -s is server scope; session scope is the empty string.

Failure scenario: a workspace with options: {default-shell: /bin/zsh} runs set-option -s ... default-shell /bin/zsh, setting a server-wide default rather than a per-session one. Every other session on that tmux server silently inherits it, including sessions tmuxp did not create. Nothing errors, so the blast radius is invisible until someone notices an unrelated session behaving oddly.

Suggested fix: use the empty scope flag for session options, and add a test asserting the emitted argv rather than the resulting behaviour, since the wrong scope still "works" locally.

Note: #1040 is a duplicate of this PR and carries the same bug.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tony
workspace(perf[builder]): poll 10ms + bulk options
73c4adf 
why: Workspace loads wait on shell prompt readiness with a 50ms
poll, coarser than tmux's 50-150ms shell-ready band, so readiness
is noticed late. Separately, the classic builder fires one
set-option per loop iteration across four hot loops (session
options, global_options, per-window options, options_after) with
no shared seam for a future batched dispatch.

what:
- Tighten _wait_for_pane_ready interval default from 0.05 to 0.01
  so prompt readiness is detected sooner (same condition).
- Add ClassicWorkspaceBuilder._bulk_set_options(items, *, target,
  scope_flag): mirrors set_option's True/False -> on/off
  normalization and propagates errors via handle_option_error.
- Route the four set-option loops through the helper: session
  (-s, session_id), global (-g, None), per-window (-w, window_id),
  options_after (-w, window_id).
- Add tests/workspace/test_builder_bulk_options.py covering scope
  application, on/off normalization, empty no-op, and OptionError
  propagation.

Salvaged from PR #1040, adapted from the pre-refactor single-file
builder.py onto the builder package's classic.py. The helper body
issues N round-trips today; the batch-shaped API defers the perf
gain to a future libtmux batching API.
@tony
tony force-pushed the builder-bulk-options branch from 8b2e68b to 73c4adf Compare October 24, 2026 09:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@tony
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.