GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Bytewax engine create configmap from object (#3821) · tqtensor/feast@c6eac2d

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

sdk/python/feast/infra/materialization/contrib/bytewax
- bytewax_materialization_engine.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_engine.py‎`

Copy file name to clipboardExpand all lines: sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_engine.py

+3-9Lines changed: 3 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,7 @@ def __init__(`
`111`	`111`	`self.offline_store = offline_store`
`112`	`112`	`self.online_store = online_store`
`113`	`113`
	`114`	`+ # TODO: Configure k8s here`
`114`	`115`	`k8s_config.load_config()`
`115`	`116`
`116`	`117`	`self.k8s_client = client.api_client.ApiClient()`
`@@ -298,9 +299,6 @@ def _create_kubernetes_job(self, job_id, paths, feature_view):`
`298`	`299`	`len(paths), # Create a pod for each parquet file`
`299`	`300`	`self.batch_engine_config.env,`
`300`	`301`	`)`
`301`		`- logger.info(`
`302`		- f"Created job `dataflow-{job_id}` on namespace `{self.namespace}`"
`303`		`- )`
`304`	`302`	`except FailToCreateError as failures:`
`305`	`303`	`return BytewaxMaterializationJob(job_id, self.namespace, error=failures)`
`306`	`304`
`@@ -309,11 +307,7 @@ def _create_kubernetes_job(self, job_id, paths, feature_view):`
`309`	`307`	`def _create_configuration_map(self, job_id, paths, feature_view, namespace):`
`310`	`308`	`"""Create a Kubernetes configmap for this job"""`
`311`	`309`
`312`		`- if self.repo_config.repo_path:`
`313`		`- feature_store_path = get_default_yaml_file_path(self.repo_config.repo_path)`
`314`		`- feature_store_configuration = feature_store_path.read_text()`
`315`		`- else:`
`316`		`- feature_store_configuration = yaml.dump(self.repo_config.dict())`
	`310`	`+ feature_store_configuration = yaml.dump(self.repo_config.dict())`
`317`	`311`
`318`	`312`	`materialization_config = yaml.dump(`
`319`	`313`	`{"paths": paths, "feature_view": feature_view.name}`
`@@ -364,7 +358,7 @@ def _create_job_definition(self, job_id, namespace, pods, env, index_offset=0):`
`364`	`358`	`},`
`365`	`359`	`{`
`366`	`360`	`"name": "BYTEWAX_REPLICAS",`
`367`		`- "value": "1",`
	`361`	`+ "value": f"{pods}",`
`368`	`362`	`},`
`369`	`363`	`{`
`370`	`364`	`"name": "BYTEWAX_KEEP_CONTAINER_ALIVE",`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.