GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(webapp): use white text on solid indigo backgrounds in light mode by claude[bot] · Pull Request #4536 · triggerdotdev/trigger.dev

Conversation

@claude

@claude claude Bot commented Aug 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Requested by Eric Allam · Slack thread

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

Verified on the preview deployment in light mode on 2026-08-08: the "Mark error as…" button label renders white on the indigo background and reads correctly. Dark mode is unchanged. The calendar selected-day fix is the same one-token swap — to check it, open any date picker and confirm the selected day reads white on indigo.


Changelog

Before: in light mode, the "Mark error as…" button on the error detail page rendered its label and icon in dark grey on the solid indigo background — low contrast and hard to read. Selected dates in the calendar had the same problem.

After: both render white text on the indigo background, in light and dark mode alike.

How: these surfaces were using the text-text-bright token, which flips with the theme (near-white in dark mode, near-black in light mode). That is correct on a theme-aware background, but wrong on a background that stays solid indigo in both themes. Swapped to a hardcoded text-white on just those spots, matching the existing pattern in apps/webapp/app/components/primitives/Buttons.tsx where the primary button hardcodes text-white on bg-indigo-600.

Files touched:

  • apps/webapp/app/components/primitives/Popover.tsx — the primary entry of popoverArrowTriggerVariants (trigger, text, icon). The now-redundant hover:text-white on text is dropped.
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors.$fingerprint/route.tsx — the icon inside that primary trigger.
  • apps/webapp/app/components/primitives/Calendar.tsx — the selected-day classes.

Blast radius is small: PopoverArrowTrigger variant="primary" has exactly one call site in the app (the "Mark error as…" button), so the Popover change affects that one button, plus the separate calendar selected-day fix. No token definitions changed, and no other text-text-bright call site is touched — it is correct everywhere else, since those sit on theme-aware backgrounds.


Screenshots

None yet.

💯

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@claude
fix(webapp): use white text on solid indigo backgrounds in light mode
c020176
The primary PopoverArrowTrigger variant and the calendar's selected-day
state used the theme-flipping `text-text-bright` token on a solid
`bg-indigo-600` background. In light mode that token resolves to near-black,
so the label sat as dark grey on indigo and was hard to read.

Hardcode `text-white` on these solid indigo surfaces, matching the
established pattern in Buttons.tsx.

Co-Authored-By: Claude <[email protected]>
@changeset-bot

changeset-bot Bot commented Aug 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a5f9978

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@claude claude Bot added the preview label Aug 7, 2026
@trigger-dot-bot

trigger-dot-bot Bot commented Aug 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Preview Deployment

Status Preview Billing Commit Updated
⚪ Removed – – – Nov 10, 18:04 UTC
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@claude claude Bot added preview and removed preview labels Aug 7, 2026
@ericallam
chore: re-trigger preview deploy (enterprise image path)
a5f9978
@claude
claude Bot marked this pull request as ready for review August 8, 2026 09:01
@claude

claude Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review


Generated by Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nicktrn nicktrn removed the preview label Nov 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@nicktrn @claude @ericallam
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.